Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Optimize the task scheduling logic in DataCoord #39084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

fix ut

c78c46d
Select commit
Loading
Failed to load commit list.
Open

enhance: Optimize the task scheduling logic in DataCoord #39084

fix ut
c78c46d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

81.02% (target 77.00%)

View this Pull Request on Codecov

81.02% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 84.07080% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (92bde5b) to head (c78c46d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/task_index.go 57.14% 6 Missing and 3 partials ⚠️
internal/datacoord/task_scheduler.go 80.00% 5 Missing and 2 partials ⚠️
pkg/util/merr/utils.go 0.00% 6 Missing ⚠️
internal/datacoord/session/indexnode_manager.go 85.71% 4 Missing and 1 partial ⚠️
internal/datacoord/task_analyze.go 55.55% 4 Missing ⚠️
internal/indexnode/task_scheduler.go 86.36% 2 Missing and 1 partial ⚠️
internal/indexnode/task_analyze.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39084      +/-   ##
==========================================
+ Coverage   80.99%   81.02%   +0.03%     
==========================================
  Files        1407     1407              
  Lines      198528   198674     +146     
==========================================
+ Hits       160794   160985     +191     
+ Misses      32063    32034      -29     
+ Partials     5671     5655      -16     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.47% <ø> (ø)
Go 82.97% <84.07%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/task_stats.go 92.79% <100.00%> (+0.16%) ⬆️
internal/indexnode/indexnode.go 77.82% <100.00%> (+0.09%) ⬆️
internal/indexnode/indexnode_service.go 83.83% <100.00%> (+0.12%) ⬆️
internal/indexnode/task_index.go 72.06% <100.00%> (+0.19%) ⬆️
internal/indexnode/task_stats.go 70.87% <100.00%> (+0.54%) ⬆️
internal/indexnode/util.go 61.29% <100.00%> (+18.43%) ⬆️
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/paramtable/component_param.go 98.41% <100.00%> (+0.01%) ⬆️
internal/indexnode/task_analyze.go 78.72% <0.00%> (-1.14%) ⬇️
internal/indexnode/task_scheduler.go 87.26% <86.36%> (+0.08%) ⬆️
... and 5 more

... and 35 files with indirect coverage changes