fix: build text index when loading field data #39070
Conversation
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
mergify
bot
added
dco-passed
| @@ -274,6 +274,15 @@ SegmentGrowingImpl::LoadFieldData(const LoadFieldDataInfo& infos) { | |||
| storage::GetByteSizeOfFieldDatas(field_data)); | |||
| } | |||
|
|
|||
| // build text match index | |||
| if (field_meta.enable_match()) { | |||
| auto index = GetTextIndex(field_id); | |||
There was a problem hiding this comment.
can get index at this interface ? index not build before ?
There was a problem hiding this comment.
index is created when at the constructor of SegmentGrowingImpl
| int64_t offset = 0; | ||
| for (const auto& data : field_datas) { | ||
| auto n = data->get_num_rows(); | ||
| wrapper_->add_data( | ||
| static_cast<const std::string*>(data->Data()), n, offset); | ||
| offset += n; |
There was a problem hiding this comment.
no need to consider nullable ?
|
@SpadeA-Tang cpp-unit-test check failed, comment |
Signed-off-by: SpadeA-Tang <[email protected]>
sre-ci-robot
added
size/L
Signed-off-by: SpadeA-Tang <[email protected]>
|
@SpadeA-Tang cpp-unit-test check failed, comment |
Signed-off-by: SpadeA-Tang <[email protected]>
|
@SpadeA-Tang E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39070 +/- ##
==========================================
+ Coverage 81.14% 81.16% +0.01%
==========================================
Files 1389 1389
Lines 196556 196624 +68
==========================================
+ Hits 159491 159581 +90
+ Misses 31473 31459 -14
+ Partials 5592 5584 -8
|
|
/run-cpu-e2e |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, SpadeA-Tang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: milvus-io#39053 may fix milvus-io#38644 which could be caused by milvus-io#39053 --------- Signed-off-by: SpadeA-Tang <[email protected]>
fix: #39053 may fix #38644 which could be caused by #39053 --------- Signed-off-by: SpadeA-Tang <[email protected]>
fix: #39053
may fix #38644 which could be caused by #39053