Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Reduce memory usage of BF in DataNode and QueryNode #38913

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

bigsheeper
Copy link
Contributor

  1. DataNode: Skip generating BF during the insert phase (BF will be regenerated during the sync phase).
  2. QueryNode: Skip generating or maintaining BF for growing segments; deletion checks will be handled in the segcore.

issue: #37630

pr: #38129

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (5199415) to head (62d06d5).
Report is 7 commits behind head on 2.5.

Files with missing lines Patch % Lines
...nternal/flushcommon/writebuffer/l0_write_buffer.go 16.66% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38913       +/-   ##
===========================================
+ Coverage   69.58%   81.03%   +11.45%     
===========================================
  Files         297     1399     +1102     
  Lines       26557   196808   +170251     
===========================================
+ Hits        18480   159488   +141008     
- Misses       8077    31704    +23627     
- Partials        0     5616     +5616     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.58% <ø> (ø)
Go 82.98% <69.69%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 67.03% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.39% <100.00%> (ø)
...nternal/flushcommon/writebuffer/l0_write_buffer.go 40.47% <16.66%> (ø)

... and 1099 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 1, 2025
@mergify mergify bot removed the ci-passed label Jan 14, 2025
@czs007 czs007 self-assigned this Jan 14, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 14, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun cpp-unit-test

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 15, 2025
@sre-ci-robot sre-ci-robot merged commit 5b0bb4c into milvus-io:2.5 Jan 15, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants