Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix slow dist handle and slow observe #38906

Open
wants to merge 11 commits into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Jan 1, 2025

  1. Provide partition&channel level indexing in the collection target.
  2. Make SegmentAction not wait for distribution.
  3. Remove scheduler and target manager mutex
  4. Optimize logging to reduce CPU overhead.

issue: #37630

pr: #38566

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 91.13924% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (b6be11c) to head (f9fdd0b).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/task/scheduler.go 88.14% 15 Missing and 1 partial ⚠️
...rnal/querycoordv2/observers/collection_observer.go 84.00% 4 Missing ⚠️
internal/querycoordv2/meta/target.go 98.03% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38906      +/-   ##
==========================================
- Coverage   80.41%   80.40%   -0.01%     
==========================================
  Files        1080     1080              
  Lines      169974   169943      -31     
==========================================
- Hits       136687   136648      -39     
- Misses      28784    28786       +2     
- Partials     4503     4509       +6     
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 96.12% <100.00%> (+0.10%) ⬆️
internal/querycoordv2/meta/target_manager.go 89.06% <100.00%> (-1.31%) ⬇️
internal/querycoordv2/task/action.go 100.00% <100.00%> (+0.83%) ⬆️
internal/querycoordv2/task/task.go 97.42% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/utils/util.go 86.22% <100.00%> (-2.40%) ⬇️
pkg/metrics/querycoord_metrics.go 100.00% <ø> (ø)
internal/querycoordv2/meta/target.go 92.15% <98.03%> (+2.41%) ⬆️
...rnal/querycoordv2/observers/collection_observer.go 86.52% <84.00%> (-0.39%) ⬇️
internal/querycoordv2/task/scheduler.go 88.20% <88.14%> (-1.26%) ⬇️

... and 29 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 1, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 2, 2025
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 3, 2025
@mergify mergify bot removed the ci-passed label Jan 3, 2025
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot added the ci-passed label Jan 3, 2025
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 14, 2025
@czs007 czs007 self-assigned this Jan 14, 2025
@bigsheeper
Copy link
Contributor Author

rerun ut

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please ask for approval from czs007 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 15, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants