Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix slow dist handle and slow observe #38905

Merged
merged 13 commits into from
Jan 16, 2025

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Jan 1, 2025

  1. Provide partition&channel level indexing in the collection target.
  2. Make SegmentAction not wait for distribution.
  3. Remove scheduler and target manager mutex
  4. Optimize logging to reduce CPU overhead.

issue: #37630

pr: #38566

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@sre-ci-robot sre-ci-robot requested a review from aoiasd January 1, 2025 08:51
@mergify mergify bot added the dco-passed DCO check passed. label Jan 1, 2025
@sre-ci-robot sre-ci-robot requested a review from congqixia January 1, 2025 08:51
@mergify mergify bot added the kind/bug Issues or changes related a bug label Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 88.42975% with 28 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (4cb47b3) to head (d62b8c5).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querycoordv2/task/scheduler.go 82.70% 22 Missing and 1 partial ⚠️
...rnal/querycoordv2/observers/collection_observer.go 83.33% 4 Missing ⚠️
internal/querycoordv2/meta/target.go 98.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38905       +/-   ##
===========================================
+ Coverage   69.50%   81.03%   +11.52%     
===========================================
  Files         300     1404     +1104     
  Lines       26763   197416   +170653     
===========================================
+ Hits        18602   159972   +141370     
- Misses       8161    31815    +23654     
- Partials        0     5629     +5629     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.50% <ø> (ø)
Go 83.00% <88.42%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 96.13% <100.00%> (ø)
internal/querycoordv2/meta/target_manager.go 86.93% <100.00%> (ø)
internal/querycoordv2/task/action.go 96.66% <100.00%> (ø)
internal/querycoordv2/task/task.go 94.22% <100.00%> (ø)
internal/querycoordv2/utils/util.go 85.54% <100.00%> (ø)
pkg/metrics/querycoord_metrics.go 100.00% <ø> (ø)
internal/querycoordv2/meta/target.go 93.06% <98.30%> (ø)
...rnal/querycoordv2/observers/collection_observer.go 86.52% <83.33%> (ø)
internal/querycoordv2/task/scheduler.go 86.69% <82.70%> (ø)

... and 1095 files with indirect coverage changes

@mergify mergify bot removed the ci-passed label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 2, 2025
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 3, 2025
@mergify mergify bot removed the ci-passed label Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 3, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 3, 2025
Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007 czs007 self-assigned this Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 15, 2025
@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007 czs007 added this to the 2.5.4 milestone Jan 15, 2025
@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 15, 2025

rerun go-sdk

1 similar comment
@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 16, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Jan 16, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit 9d2a0e7 into milvus-io:2.5 Jan 16, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants