Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Remove frequently updating metric to avoid mutex contention #38778

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

pr: #38775

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.43%. Comparing base (8bf0f0b) to head (421c49b).
Report is 9 commits behind head on 2.5.

❗ There is a different number of reports uploaded between BASE (8bf0f0b) and HEAD (421c49b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8bf0f0b) HEAD (421c49b)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38778       +/-   ##
===========================================
- Coverage   81.07%   69.43%   -11.65%     
===========================================
  Files        1400      298     -1102     
  Lines      197102    26650   -170452     
===========================================
- Hits       159801    18504   -141297     
+ Misses      31678     8146    -23532     
+ Partials     5623        0     -5623     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.43% <ø> (-0.16%) ⬇️
Go ∅ <ø> (∅)

see 1117 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 26, 2024
@bigsheeper bigsheeper changed the title fix: [2.5] Fix index meta mutex contention fix: [2.5] Remove frequently updating metric to avoid mutex contention Dec 31, 2024
@mergify mergify bot removed the ci-passed label Dec 31, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jan 15, 2025
@czs007 czs007 added this to the 2.5.4 milestone Jan 15, 2025
@mergify mergify bot removed the ci-passed label Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

rerun cpp-unit-test

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit c741b8b into milvus-io:2.5 Jan 16, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants