Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Remove frequently updating metric to avoid mutex contention #38776

Open
wants to merge 8 commits into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

Reduce the frequency of updateIndexTasksMetrics to avoid holding the mutex for long periods.

pr: #38775

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (995d5e1) to head (96fb8fd).
Report is 1 commits behind head on 2.4.

Current head 96fb8fd differs from pull request most recent head d2d11d9

Please upload reports for the commit d2d11d9 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38776       +/-   ##
===========================================
- Coverage   80.44%   70.42%   -10.02%     
===========================================
  Files        1079     1079               
  Lines      169909   169906        -3     
===========================================
- Hits       136678   119653    -17025     
- Misses      28730    45749    +17019     
- Partials     4501     4504        +3     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 97.62% <100.00%> (+1.63%) ⬆️
internal/querycoordv2/task/scheduler.go 90.05% <100.00%> (+0.72%) ⬆️

... and 270 files with indirect coverage changes

@bigsheeper bigsheeper changed the title fix: [2.4] Fix index meta mutex contention fix: [2.4] Remove frequently updating metric to avoid mutex contention Dec 31, 2024
@mergify mergify bot removed the ci-passed label Dec 31, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 31, 2024
@mergify mergify bot added the ci-passed label Dec 31, 2024
@bigsheeper bigsheeper force-pushed the 2412-opt-index-meta-mutex-2.4 branch from ced2aa0 to d941e90 Compare January 1, 2025 08:31
@mergify mergify bot removed the ci-passed label Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please ask for approval from liliu-z after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 15, 2025
@mergify mergify bot removed the ci-passed label Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants