-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.4] Remove frequently updating metric to avoid mutex contention #38776
base: 2.4
Are you sure you want to change the base?
fix: [2.4] Remove frequently updating metric to avoid mutex contention #38776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #38776 +/- ##
===========================================
- Coverage 80.44% 70.42% -10.02%
===========================================
Files 1079 1079
Lines 169909 169906 -3
===========================================
- Hits 136678 119653 -17025
- Misses 28730 45749 +17019
- Partials 4501 4504 +3
|
Signed-off-by: bigsheeper <[email protected]>
ced2aa0
to
d941e90
Compare
@bigsheeper E2e jenkins job failed, comment |
@bigsheeper E2e jenkins job failed, comment |
…pt-index-meta-mutex-2.4
Signed-off-by: bigsheeper <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pt-index-meta-mutex-2.4
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper E2e jenkins job failed, comment |
issue: #37630
Reduce the frequency of
updateIndexTasksMetrics
to avoid holding the mutex for long periods.pr: #38775