Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add vector index mgr to remove vector index type dependency #36843

Merged

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Oct 14, 2024

issue: #34298

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Oct 14, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 14, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from d5c3f21 to 949ce5b Compare October 14, 2024 09:14
@mergify mergify bot added the ci-passed label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 10.07%. Comparing base (b0d5866) to head (8d43c5e).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/vector_index_c.cpp 0.00% 11 Missing ⚠️
internal/core/src/index/ScalarIndex.h 0.00% 3 Missing ⚠️
internal/core/src/index/VectorIndex.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #36843       +/-   ##
===========================================
- Coverage   81.51%   10.07%   -71.44%     
===========================================
  Files        1308      285     -1023     
  Lines      156200    25352   -130848     
===========================================
- Hits       127324     2555   -124769     
+ Misses      23753    22797      -956     
+ Partials     5123        0     -5123     
Files with missing lines Coverage Δ
internal/core/src/index/Index.h 50.00% <ø> (-44.45%) ⬇️
internal/core/src/index/ScalarIndex.h 2.56% <0.00%> (-25.22%) ⬇️
internal/core/src/index/VectorIndex.h 5.00% <0.00%> (-51.76%) ⬇️
internal/core/src/segcore/vector_index_c.cpp 0.00% <0.00%> (ø)

... and 1238 files with indirect coverage changes

@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from 949ce5b to 825fdfa Compare October 14, 2024 12:04
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 14, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 14, 2024
@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from 825fdfa to 67f3c53 Compare October 15, 2024 05:02
@mergify mergify bot removed the ci-passed label Oct 15, 2024
@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from 67f3c53 to ef763a9 Compare October 15, 2024 05:31
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from ef763a9 to c89bfb5 Compare October 15, 2024 07:02
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 15, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from c89bfb5 to b20e680 Compare October 15, 2024 10:13
@mergify mergify bot added the ci-passed label Oct 15, 2024
@foxspy foxspy force-pushed the remove_vector_index_type_dependency branch from b20e680 to 8d43c5e Compare October 15, 2024 14:47
@mergify mergify bot removed the ci-passed label Oct 15, 2024
@foxspy foxspy changed the title enhance : add vector index mgr to remove vector index type dependency enhance: add vector index mgr to remove vector index type dependency Oct 15, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Oct 15, 2024
Copy link
Contributor

mergify bot commented Oct 15, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 16, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 16, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3de57ec into milvus-io:master Oct 17, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants