Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bulkinsert supports null in csv formats #35912

Merged
merged 2 commits into from
Sep 9, 2024

feat: add unit & integration test

387f93f
Select commit
Loading
Failed to load commit list.
Merged

enhance: Bulkinsert supports null in csv formats #35912

feat: add unit & integration test
387f93f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 9, 2024 in 1s

72.61% (target 77.00%)

View this Pull Request on Codecov

72.61% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.61%. Comparing base (b2eb9fe) to head (387f93f).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/importutilv2/csv/row_parser.go 69.69% 5 Missing and 5 partials ⚠️
internal/util/importutilv2/reader.go 50.00% 1 Missing and 1 partial ⚠️
internal/util/importutilv2/option.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35912      +/-   ##
==========================================
- Coverage   81.60%   72.61%   -9.00%     
==========================================
  Files        1264     1264              
  Lines      150692   150789      +97     
==========================================
- Hits       122976   109488   -13488     
- Misses      22826    36406   +13580     
- Partials     4890     4895       +5     
Files with missing lines Coverage Δ
internal/util/importutilv2/csv/reader.go 71.92% <100.00%> (ø)
internal/util/testutil/test_util.go 93.29% <100.00%> (+0.03%) ⬆️
internal/util/importutilv2/option.go 67.92% <83.33%> (+1.96%) ⬆️
internal/util/importutilv2/reader.go 65.38% <50.00%> (-4.19%) ⬇️
internal/util/importutilv2/csv/row_parser.go 69.66% <69.69%> (-0.10%) ⬇️

... and 239 files with indirect coverage changes