Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: clean failed/timeout compaction task in compactionHandler #34991

Closed
wants to merge 1 commit into from

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Jul 25, 2024

issue: #35711

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Jul 25, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby July 25, 2024 04:22
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 25, 2024
Copy link
Contributor

mergify bot commented Jul 25, 2024

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jul 25, 2024
Copy link
Contributor

mergify bot commented Jul 25, 2024

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 77.68595% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (302650a) to head (8f85d58).
Report is 255 commits behind head on master.

Current head 8f85d58 differs from pull request most recent head 5e4d13c

Please upload reports for the commit 5e4d13c to get more accurate results.

Files with missing lines Patch % Lines
internal/datacoord/compaction_task_mix.go 38.09% 13 Missing ⚠️
internal/datacoord/compaction_task_clustering.go 81.08% 6 Missing and 1 partial ⚠️
internal/datacoord/partition_stats_meta.go 72.72% 4 Missing and 2 partials ⚠️
internal/datacoord/compaction_task_l0.go 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34991      +/-   ##
==========================================
- Coverage   81.10%   80.93%   -0.18%     
==========================================
  Files        1360     1319      -41     
  Lines      190840   182764    -8076     
==========================================
- Hits       154789   147920    -6869     
+ Misses      30569    29676     -893     
+ Partials     5482     5168     -314     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.13% <ø> (-1.75%) ⬇️
Go 83.18% <77.68%> (-0.10%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/compaction.go 73.45% <100.00%> (+1.94%) ⬆️
internal/datacoord/compaction_task.go 100.00% <ø> (ø)
pkg/util/merr/errors.go 92.18% <ø> (ø)
pkg/util/merr/utils.go 84.11% <100.00%> (+0.11%) ⬆️
internal/datacoord/compaction_task_l0.go 92.65% <90.00%> (-1.08%) ⬇️
internal/datacoord/partition_stats_meta.go 52.04% <72.72%> (+8.42%) ⬆️
internal/datacoord/compaction_task_clustering.go 79.38% <81.08%> (+1.95%) ⬆️
internal/datacoord/compaction_task_mix.go 68.16% <38.09%> (+1.49%) ⬆️

... and 431 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 25, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 25, 2024
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. ci-passed labels Jul 25, 2024
@wayblink
Copy link
Contributor Author

rerun ut

@mergify mergify bot added ci-passed and removed ci-passed labels Jul 26, 2024
@mergify mergify bot removed the ci-passed label Aug 23, 2024
@wayblink wayblink force-pushed the compaction-clean branch 3 times, most recently from e645c88 to 9e72d2f Compare August 26, 2024 11:39
@wayblink wayblink changed the title wip: enhance compaction clean enhance: clean failed/timeout compaction task in compactionHandler Aug 26, 2024
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Aug 26, 2024
@wayblink wayblink force-pushed the compaction-clean branch 2 times, most recently from 5be9b4a to 6067ca8 Compare August 27, 2024 02:15
Copy link
Contributor

mergify bot commented Oct 23, 2024

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 23, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 24, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 24, 2024

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 24, 2024

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 24, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 25, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink
Copy link
Contributor Author

rerun ut

@wayblink wayblink force-pushed the compaction-clean branch 2 times, most recently from 32e6be7 to 0ccdb31 Compare October 30, 2024 02:58
Copy link
Contributor

mergify bot commented Oct 30, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 30, 2024
@mergify mergify bot removed the ci-passed label Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@wayblink
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 31, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 27, 2024

@wayblink go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 27, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 27, 2024

@wayblink cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 28, 2024
@stale stale bot closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants