Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Update protobuf-go to protobuf-go v2 #34394

Merged
merged 1 commit into from
Jul 29, 2024
Merged

enhance: Update protobuf-go to protobuf-go v2 #34394

merged 1 commit into from
Jul 29, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #34252

@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file area/test sig/testing test/integration integration test labels Jul 3, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 3, 2024
@weiliu1031 weiliu1031 mentioned this pull request Jul 3, 2024
Merged
@weiliu1031 weiliu1031 force-pushed the update_protobuf_go branch from 6e90660 to c6f58af Compare July 3, 2024 06:50
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jul 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the update_protobuf_go branch from c6f58af to 46f48b6 Compare July 3, 2024 13:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 3, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the update_protobuf_go branch 2 times, most recently from 22b7896 to ad8c6e9 Compare July 4, 2024 06:24
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 4, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031 weiliu1031 force-pushed the update_protobuf_go branch 5 times, most recently from a24ff59 to 25ca25c Compare July 8, 2024 10:16
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 force-pushed the update_protobuf_go branch from 25ca25c to 0c50b4e Compare July 9, 2024 06:14
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jul 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.78049% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (4ee6c69) to head (edd9e1f).
Report is 17 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34394      +/-   ##
==========================================
- Coverage   80.98%   80.95%   -0.04%     
==========================================
  Files        1190     1190              
  Lines      143288   143323      +35     
==========================================
- Hits       116048   116032      -16     
- Misses      22817    22854      +37     
- Partials     4423     4437      +14
Files Coverage Δ
internal/datacoord/analyze_meta.go 100.00% <ø> (ø)
internal/datacoord/channel.go 86.20% <ø> (ø)
internal/datacoord/channel_store.go 80.49% <ø> (ø)
internal/datacoord/compaction_task_meta.go 65.78% <ø> (ø)
internal/datacoord/import_job.go 100.00% <ø> (ø)
internal/datacoord/import_task.go 96.49% <ø> (ø)
internal/datacoord/index_meta.go 95.19% <ø> (ø)
internal/datacoord/meta.go 88.51% <ø> (ø)
internal/datacoord/segment_info.go 85.21% <ø> (ø)
...ternal/datanode/compaction/clustering_compactor.go 65.20% <ø> (ø)
... and 73 more

... and 25 files with indirect coverage changes

congqixia
congqixia approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c45f38a into milvus-io:master Jul 29, 2024
10 of 12 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 29, 2024
@congqixia
enhance: Refine protobuf dependency installation in Makefile
040d914 
Related to milvus-io#34394

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Jul 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 29, 2024
@congqixia
enhance: Refine protobuf dependency installation in Makefile (#35072)
d36cfe7 
Related to #34394

---------

Signed-off-by: Congqi Xia <[email protected]>
OxalisCu pushed a commit to OxalisCu/milvus that referenced this pull request Jul 30, 2024
@congqixia @OxalisCu
enhance: Refine protobuf dependency installation in Makefile (milvus-…
e915c60 
…io#35072)

Related to milvus-io#34394

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 31, 2024
@congqixia
enhance: Add depguard rules to ban deprecated proto lib
4265b7f 
See also milvus-io#34394 milvus-io#34252

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this pull request Jul 31, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Aug 1, 2024
@congqixia
enhance: Add depguard rules to ban deprecated proto lib (#35140)
dfda9f0 
See also #34394 #34252

Signed-off-by: Congqi Xia <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@weiliu1031 @sumitd2
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
26fc511 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@congqixia @sumitd2
enhance: Refine protobuf dependency installation in Makefile (milvus-…
3645777 
…io#35072)

Related to milvus-io#34394

---------

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@congqixia @sumitd2
enhance: Add depguard rules to ban deprecated proto lib (milvus-io#35140
945dc8b 
)

See also milvus-io#34394 milvus-io#34252

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
fb4cb70 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this pull request Aug 19, 2024
Merged
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@congqixia @weiliu1031
enhance: Refine protobuf dependency installation in Makefile (milvus-…
3fc5fa9 
…io#35072)

Related to milvus-io#34394

---------

Signed-off-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
f7b5039 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@congqixia @weiliu1031
enhance: Refine protobuf dependency installation in Makefile (milvus-…
ac91960 
…io#35072)

Related to milvus-io#34394

---------

Signed-off-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
7e43d57 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 19, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
1fc23a0 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Aug 21, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
81b04ed 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Aug 21, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (#34394) (#35555)
e2542a1 
issue: #34252
pr: #34394 #35072 #35084

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Aug 29, 2024
@congqixia @weiliu1031
enhance: Add depguard rules to ban deprecated proto lib (milvus-io#35140
34b2efe 
)

See also milvus-io#34394 milvus-io#34252

Co-authored-by: Congqi Xia <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this pull request Aug 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Aug 30, 2024
@weiliu1031 @congqixia
enhance: Add depguard rules to ban deprecated proto lib (#35140) (#35818
da026b1 
)

See also #34394 #34252
pr: #35140

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: congqixia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@aoiasd aoiasd Awaiting requested review from aoiasd

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@congqixia congqixia

Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @congqixia