Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [CHERRY-PICK] use already installed vcpkg #28915

Merged
merged 1 commit into from
Dec 5, 2023
Merged

enhance: [CHERRY-PICK] use already installed vcpkg #28915

merged 1 commit into from
Dec 5, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 1, 2023

issue: #28683 master pr: #28505
issue: #28686 master pr: #28703

  1. update the base image: milvusdb/milvus-env (enhance: update the base image: milvusdb/milvus-env #28505) to avoid downloading installation packages in CI workload install vcpkg and install some packages in advance
  2. use the latest image
  3. update azure-identity-cpp from beta to release

@PowderLi
enhance: use already installed vcpkg (milvus-io#28703)
63e5cc1 
1. update the base image: milvusdb/milvus-env (milvus-io#28505)
to avoid downloading installation packages in CI workload install vcpkg
and install some packages in advance
2. use the latest image
2. update azure-identity-cpp from beta to release

Signed-off-by: PowderLi <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 1, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 1, 2023
@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 2, 2023

rerun ut

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023 •
edited
Loading

Codecov Report

Merging #28915 (63e5cc1) into 2.3 (96c8e8d) will increase coverage by 0.00%.
Report is 10 commits behind head on 2.3.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #28915   +/-   ##
=======================================
  Coverage   81.98%   81.99%           
=======================================
  Files         829      820    -9     
  Lines      118686   118659   -27     
=======================================
- Hits        97310    97294   -16     
+ Misses      18163    18147   -16     
- Partials     3213     3218    +5

see 161 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 4, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

@PowderLi PowderLi changed the title enhance: use already installed vcpkg enhance: [CHERRY-PICK] use already installed vcpkg Dec 4, 2023
@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

1 similar comment
@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 5, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 5, 2023
@sre-ci-robot sre-ci-robot merged commit 43ec2c2 into milvus-io:2.3 Dec 5, 2023
15 checks passed
@PowderLi PowderLi deleted the 2.3-preinstall-vcpkg branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@LoveEachDay LoveEachDay Awaiting requested review from LoveEachDay

Assignees

@czs007 czs007

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PowderLi @czs007 @sre-ci-robot