enhance: enable assert method to format arguments (#28812) #28907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now the assert method in segcore could accept a string information, too many codes don't print the value they assert. make it happy related milvus-io#28811 --------- Signed-off-by: yah01 <[email protected]>
mergify
bot
added
dco-passed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #28907 +/- ##
==========================================
+ Coverage 81.98% 82.00% +0.01%
==========================================
Files 829 820 -9
Lines 118659 118631 -28
==========================================
- Hits 97283 97282 -1
+ Misses 18157 18138 -19
+ Partials 3219 3211 -8
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now the assert method in segcore could accept a string information, too many codes don't print the value they assert.
make it happy
related #28811
pr: #28812