Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: move GetVector_EmptySparseVector ut to growing test #39234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengbuqian
Copy link
Collaborator

@zhengbuqian zhengbuqian commented Jan 14, 2025

in the latest version of Knowhere, only growing sparse index of IP metric will have raw data in index, thus no need to test GetVectorById of sealed index.

issue: #35853

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 14, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 14, 2025
Copy link
Contributor

mergify bot commented Jan 14, 2025

@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (e501025) to head (558d02b).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39234       +/-   ##
===========================================
+ Coverage   69.65%   81.07%   +11.42%     
===========================================
  Files         299     1404     +1105     
  Lines       26799   198260   +171461     
===========================================
+ Hits        18667   160747   +142080     
- Misses       8132    31862    +23730     
- Partials        0     5651     +5651     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.65% <ø> (ø)
Go 82.99% <ø> (∅)

see 1105 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 14, 2025

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 14, 2025

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Jan 15, 2025
@zhengbuqian zhengbuqian changed the title enhance: update knowhere version enhance: move GetVector_EmptySparseVector ut to growing test Jan 15, 2025
Copy link
Contributor

mergify bot commented Jan 15, 2025

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants