Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: When an unrecoverable error occurs, return instead of swap #35913

Closed
1 task done
fengjun2016 opened this issue Sep 2, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@fengjun2016
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

When an unrecoverable error occurs, return error directly instead of swap

截屏2024-09-02 23 24 54

Why is this needed?

截屏2024-09-02 22 53 15
截屏2024-09-02 22 53 30
截屏2024-09-02 22 54 13

Anything else?

No response

@chyezh
Copy link
Contributor

chyezh commented Sep 3, 2024

/assign

@chyezh
Copy link
Contributor

chyezh commented Sep 3, 2024

thx for your catch.

producerWithResumingError type is a utility type to handle the Condvar logic for ResumableProducer.
So after creating the producer, we must record the error and producer in producerWithResumingError to notify the method Produce.

So we cannot move the SwapProducer to the position after error handling.

@chyezh
Copy link
Contributor

chyezh commented Sep 5, 2024

closed, as previous comment.

@chyezh chyezh closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

2 participants