Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: decouple knowhere and milvus #35827

Closed
wants to merge 3 commits into from
Closed

enhance: decouple knowhere and milvus #35827

wants to merge 3 commits into from

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Aug 29, 2024

issue: #34298

@foxspy
Copy link
Contributor Author

foxspy commented Aug 29, 2024

/hold
for ci test

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: foxspy
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 29, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from b524413 to d79fcce Compare August 30, 2024 02:21
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from d79fcce to 77952f4 Compare August 30, 2024 10:05
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch 2 times, most recently from 8dd30a5 to cf283e6 Compare September 2, 2024 12:47
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from cf283e6 to aced72d Compare September 3, 2024 01:55
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from aced72d to bc2b7ec Compare September 3, 2024 02:10
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from bc2b7ec to ca85d5c Compare September 3, 2024 04:23
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from ca85d5c to 7d75e4d Compare September 3, 2024 09:47
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 3, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 7d75e4d to 670e12a Compare September 5, 2024 02:56
@foxspy
Copy link
Contributor Author

foxspy commented Sep 5, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch 2 times, most recently from c1e81e9 to 91ea18d Compare October 8, 2024 11:27
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 8, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 8, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 91ea18d to 0d14320 Compare October 8, 2024 12:43
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 8, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 8, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 0d14320 to 1199059 Compare October 9, 2024 03:46
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

foxspy added 2 commits October 9, 2024 16:17
@foxspy
add index option check
a196b8c 
Signed-off-by: xianliang.li <[email protected]>
@foxspy
add index config check
59f9bcf 
Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 1199059 to f624245 Compare October 9, 2024 08:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 9, 2024

/run-cpu-e2e

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from f624245 to 1c00b46 Compare October 9, 2024 13:12
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 1c00b46 to f677188 Compare October 11, 2024 08:31
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from f677188 to 0778f54 Compare October 11, 2024 11:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy
revert config
e8bde11 
Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the decouple_milvus_knowhere branch from 0778f54 to e8bde11 Compare October 12, 2024 05:59
This was referenced Oct 14, 2024
Merged
Merged
Merged
@foxspy
Copy link
Contributor Author

foxspy commented Oct 14, 2024

split this pr into #36843 #36844 #36846

@foxspy foxspy closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
area/compilation area/test dco-passed DCO check passed. do-not-merge/hold kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foxspy @sre-ci-robot