Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Optimize delegator extra cpu usage #34252

Closed
1 task done
weiliu1031 opened this issue Jun 28, 2024 · 5 comments
Closed
1 task done

[Enhancement]: Optimize delegator extra cpu usage #34252

weiliu1031 opened this issue Jun 28, 2024 · 5 comments
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@weiliu1031
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

delegator has extra cpu usage than worker, which caused by reduce/marshal/unmarshal.

Why is this needed?

No response

Anything else?

No response
@weiliu1031 weiliu1031 added the kind/enhancement Issues or changes related to enhancement label Jun 28, 2024
@weiliu1031 weiliu1031 mentioned this issue Jul 3, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 29, 2024
@weiliu1031
enhance: Update protobuf-go to protobuf-go v2 (#34394)
c45f38a 
issue: #34252

Signed-off-by: Wei Liu <[email protected]>
@stale Stale
Copy link

stale bot commented Jul 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jul 30, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Jul 31, 2024
@congqixia
enhance: Add depguard rules to ban deprecated proto lib
4265b7f 
See also milvus-io#34394 milvus-io#34252

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jul 31, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Aug 1, 2024
@congqixia
enhance: Add depguard rules to ban deprecated proto lib (#35140)
dfda9f0 
See also #34394 #34252

Signed-off-by: Congqi Xia <[email protected]>
@xiaofan-luan
Copy link
Collaborator

how much cpu usage can be improving by upgrading protobuf? @weiliu1031

@stale stale bot removed the stale indicates no udpates for 30 days label Aug 3, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@weiliu1031 @sumitd2
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
26fc511 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this issue Aug 6, 2024
@congqixia @sumitd2
enhance: Add depguard rules to ban deprecated proto lib (milvus-io#35140
945dc8b 
)

See also milvus-io#34394 milvus-io#34252

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Aug 19, 2024
@weiliu1031
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
fb4cb70 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Aug 19, 2024
Merged
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Aug 19, 2024
@weiliu1031
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
f7b5039 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Aug 19, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
7e43d57 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Aug 19, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
1fc23a0 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Aug 21, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (milvus-io#34394)
81b04ed 
issue: milvus-io#34252

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Aug 21, 2024
@weiliu1031 @congqixia
enhance: Update protobuf-go to protobuf-go v2 (#34394) (#35555)
e2542a1 
issue: #34252
pr: #34394 #35072 #35084

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: Congqi Xia <[email protected]>
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this issue Aug 29, 2024
@congqixia @weiliu1031
enhance: Add depguard rules to ban deprecated proto lib (milvus-io#35140
34b2efe 
)

See also milvus-io#34394 milvus-io#34252

Co-authored-by: Congqi Xia <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Aug 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Aug 30, 2024
@weiliu1031 @congqixia
enhance: Add depguard rules to ban deprecated proto lib (#35140) (#35818
da026b1 
)

See also #34394 #34252
pr: #35140

Signed-off-by: Wei Liu <[email protected]>
Co-authored-by: congqixia <[email protected]>
@stale Stale
Copy link

stale bot commented Sep 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Sep 2, 2024
@xiaofan-luan
Copy link
Collaborator

I thinks it's kind of done, try v2.4.10 to improve

@stale stale bot removed the stale indicates no udpates for 30 days label Sep 3, 2024
@stale Stale
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 9, 2024
@stale stale bot closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaofan-luan @weiliu1031