fix: fix query incorrect in case of concurrent delete (#38991)

#38961 Signed-off-by: luzhang <[email protected]> Co-authored-by: luzhang <[email protected]>
milvus-io · Jan 6, 2025 · 8165044 · 8165044
1 parent 731e882
commit 8165044
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/internal/core/src/segcore/DeletedRecord.h b/internal/core/src/segcore/DeletedRecord.h
@@ -194,6 +194,19 @@ class DeletedRecord {
             accessor.lower_bound(std::make_pair(query_timestamp, 0));
 
         auto it = start_iter;
+
+        // when end_iter point to skiplist end, concurrent delete may append new value
+        // after lower_bound() called, so end_iter is not logical valid.
+        if (end_iter == accessor.end()) {
+            while (it != accessor.end() && it->first <= query_timestamp) {
+                if (it->second < insert_barrier) {
+                    bitset.set(it->second);
+                }
+                it++;
+            }
+            return;
+        }
+
         while (it != accessor.end() && it != end_iter) {
             if (it->second < insert_barrier) {
                 bitset.set(it->second);