Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick] Add merr package to utilize milvus error (#645) #648

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Jan 10, 2024

This PR:

  • Add merr package, which is simplified version from milvus main repo
  • Add mock API due to proto update

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 January 10, 2024 06:30
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XL Denotes a PR that changes 500-999 lines. labels Jan 10, 2024
This PR:
- Bump version to 2.4.0-dev
- Add merr package, which is simplified version from milvus main repo
- Add mock API due to proto update

---------

Signed-off-by: Congqi Xia <[email protected]>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (66ba4c6) 74.95% compared to head (361dd9f) 73.26%.
Report is 1 commits behind head on v2.3.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.3.x     #648      +/-   ##
==========================================
- Coverage   74.95%   73.26%   -1.70%     
==========================================
  Files          44       46       +2     
  Lines        4053     4200     +147     
==========================================
+ Hits         3038     3077      +39     
- Misses        915     1022     +107     
- Partials      100      101       +1     
Files Coverage Δ
merr/errors.go 55.55% <55.55%> (ø)
merr/utils.go 17.11% <17.11%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Jan 17, 2024
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Jan 17, 2024
@yah01
Copy link
Member

yah01 commented Jan 17, 2024

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 17, 2024
@sre-ci-robot sre-ci-robot merged commit 5ed4388 into milvus-io:v2.3.x Jan 17, 2024
7 checks passed
@congqixia congqixia deleted the cp_645 branch February 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants