Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the replicate message api #622

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 9, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Nov 9, 2023
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #622 (633ea75) into master (415f277) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   74.60%   74.86%   +0.26%     
==========================================
  Files          42       44       +2     
  Lines        4063     4121      +58     
==========================================
+ Hits         3031     3085      +54     
- Misses        920      925       +5     
+ Partials      112      111       -1     
Files Coverage Δ
client/client.go 28.94% <ø> (ø)
client/collection.go 88.69% <100.00%> (+0.10%) ⬆️
client/database.go 58.53% <100.00%> (-8.14%) ⬇️
client/index.go 78.29% <100.00%> (+0.69%) ⬆️
client/insert.go 80.00% <100.00%> (+0.07%) ⬆️
client/mq_message.go 100.00% <100.00%> (ø)
client/options.go 57.14% <ø> (ø)
client/options_msg_base.go 100.00% <100.00%> (ø)
client/partition.go 84.07% <100.00%> (+0.58%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Nov 9, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 10, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Nov 10, 2023
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Nov 10, 2023
@sre-ci-robot sre-ci-robot merged commit 087d17c into milvus-io:master Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants