refactor: swap out interface with type where appropriate

mikerourke · Jan 16, 2024 · 69ea417 · 69ea417
1 parent 951c216
commit 69ea417
Show file tree

Hide file tree

Showing 19 changed files with 149 additions and 149 deletions.
diff --git a/src/redux/allEntities/allEntitiesReducer.ts b/src/redux/allEntities/allEntitiesReducer.ts
@@ -3,8 +3,8 @@ import { inc, lensPath, over } from "ramda";
 import {
   createReducer,
   isActionOf,
+  type Action,
   type ActionType,
-  type AnyAction,
 } from "~/redux/reduxTools";
 import {
   EntityGroup,
@@ -17,15 +17,15 @@ import {
 
 import * as allEntitiesActions from "./allEntitiesActions";
 
-export interface AllEntitiesState {
-  readonly areExistsInTargetShown: boolean;
-  readonly entityGroupInProcess: EntityGroup | null;
-  readonly fetchAllFetchStatus: FetchStatus;
-  readonly pushAllChangesFetchStatus: FetchStatus;
-  readonly toolAction: ToolAction;
-  readonly toolNameByMapping: ToolNameByMapping;
-  readonly transferCountsByEntityGroup: CountsByEntityGroup;
-}
+export type AllEntitiesState = Readonly<{
+  areExistsInTargetShown: boolean;
+  entityGroupInProcess: EntityGroup | null;
+  fetchAllFetchStatus: FetchStatus;
+  pushAllChangesFetchStatus: FetchStatus;
+  toolAction: ToolAction;
+  toolNameByMapping: ToolNameByMapping;
+  transferCountsByEntityGroup: CountsByEntityGroup;
+}>;
 
 const DEFAULT_TRANSFER_COUNTS = {
   [EntityGroup.Clients]: 0,
@@ -143,7 +143,7 @@ type AllEntitiesApiRequestAction = ActionType<
 >;
 
 function isAllEntitiesApiRequestAction(
-  action: AnyAction,
+  action: Action,
 ): action is AllEntitiesApiRequestAction {
   return isActionOf(
     [
@@ -160,7 +160,7 @@ type AllEntitiesApiSuccessAction = ActionType<
 >;
 
 function isAllEntitiesApiSuccessAction(
-  action: AnyAction,
+  action: Action,
 ): action is AllEntitiesApiSuccessAction {
   return isActionOf(
     [
@@ -177,7 +177,7 @@ type AllEntitiesApiFailureAction = ActionType<
 >;
 
 function isAllEntitiesApiFailureAction(
-  action: AnyAction,
+  action: Action,
 ): action is AllEntitiesApiFailureAction {
   return isActionOf(
     [

diff --git a/src/redux/app/appReducer.ts b/src/redux/app/appReducer.ts
@@ -4,9 +4,9 @@ import { isDevelopmentMode } from "~/utilities/environment";
 
 import * as appActions from "./appActions";
 
-export interface AppState {
-  readonly notifications: Notification[];
-}
+export type AppState = Readonly<{
+  notifications: Notification[];
+}>;
 
 export const appInitialState: AppState = {
   notifications: [],

diff --git a/src/redux/clients/clientsReducer.ts b/src/redux/clients/clientsReducer.ts
@@ -5,18 +5,18 @@ import { allEntitiesFlushed } from "~/redux/allEntities/allEntitiesActions";
 import {
   createReducer,
   isActionOf,
-  type AnyAction,
+  type Action,
   type ActionType,
 } from "~/redux/reduxTools";
 import { Mapping, type Client } from "~/types";
 
 import * as clientsActions from "./clientsActions";
 
-export interface ClientsState {
-  readonly source: Dictionary<Client>;
-  readonly target: Dictionary<Client>;
-  readonly isFetching: boolean;
-}
+export type ClientsState = Readonly<{
+  source: Dictionary<Client>;
+  target: Dictionary<Client>;
+  isFetching: boolean;
+}>;
 
 export const clientsInitialState: ClientsState = {
   source: {},
@@ -68,7 +68,7 @@ type ClientsCreateOrFetchSuccessAction = ActionType<
 >;
 
 function isClientsApiSuccessAction(
-  action: AnyAction,
+  action: Action,
 ): action is ClientsCreateOrFetchSuccessAction {
   return isActionOf(
     [clientsActions.createClients.success, clientsActions.fetchClients.success],
@@ -83,7 +83,7 @@ type ClientsApiRequestAction = ActionType<
 >;
 
 function isClientsApiRequestAction(
-  action: AnyAction,
+  action: Action,
 ): action is ClientsApiRequestAction {
   return isActionOf(
     [
@@ -102,7 +102,7 @@ type ClientsApiFailureAction = ActionType<
 >;
 
 function isClientsApiFailureAction(
-  action: AnyAction,
+  action: Action,
 ): action is ClientsApiFailureAction {
   return isActionOf(
     [
@@ -119,7 +119,7 @@ type ResetClientsStateAction = ActionType<
 >;
 
 function isResetClientsStateAction(
-  action: AnyAction,
+  action: Action,
 ): action is ResetClientsStateAction {
   return isActionOf(
     [clientsActions.deleteClients.success, allEntitiesFlushed],

diff --git a/src/redux/credentials/credentialsReducer.ts b/src/redux/credentials/credentialsReducer.ts
@@ -7,12 +7,12 @@ import {
 
 import * as credentialsActions from "./credentialsActions";
 
-export interface CredentialsState {
-  readonly source: Credentials;
-  readonly target: Credentials;
-  readonly validationErrorsByMapping: ValidationErrorsByMapping;
-  readonly validationFetchStatus: FetchStatus;
-}
+export type CredentialsState = Readonly<{
+  source: Credentials;
+  target: Credentials;
+  validationErrorsByMapping: ValidationErrorsByMapping;
+  validationFetchStatus: FetchStatus;
+}>;
 
 const DEFAULT_VALIDATION_ERRORS = {
   source: null,

diff --git a/src/redux/projects/projectsReducer.ts b/src/redux/projects/projectsReducer.ts
@@ -5,18 +5,18 @@ import { allEntitiesFlushed } from "~/redux/allEntities/allEntitiesActions";
 import {
   createReducer,
   isActionOf,
+  type Action,
   type ActionType,
-  type AnyAction,
 } from "~/redux/reduxTools";
 import { Mapping, type Project } from "~/types";
 
 import * as projectsActions from "./projectsActions";
 
-export interface ProjectsState {
-  readonly source: Dictionary<Project>;
-  readonly target: Dictionary<Project>;
-  readonly isFetching: boolean;
-}
+export type ProjectsState = Readonly<{
+  source: Dictionary<Project>;
+  target: Dictionary<Project>;
+  isFetching: boolean;
+}>;
 
 export const projectsInitialState: ProjectsState = {
   source: {},
@@ -75,7 +75,7 @@ type ProjectsCreateOrFetchSuccessAction = ActionType<
 >;
 
 function isProjectsApiSuccessAction(
-  action: AnyAction,
+  action: Action,
 ): action is ProjectsCreateOrFetchSuccessAction {
   return isActionOf(
     [
@@ -93,7 +93,7 @@ type ProjectsApiRequestAction = ActionType<
 >;
 
 function isProjectsApiRequestAction(
-  action: AnyAction,
+  action: Action,
 ): action is ProjectsApiRequestAction {
   return isActionOf(
     [
@@ -112,7 +112,7 @@ type ProjectsApiFailureAction = ActionType<
 >;
 
 function isProjectsApiFailureAction(
-  action: AnyAction,
+  action: Action,
 ): action is ProjectsApiFailureAction {
   return isActionOf(
     [
@@ -129,7 +129,7 @@ type ResetProjectsStateAction = ActionType<
 >;
 
 function isResetProjectsStateAction(
-  action: AnyAction,
+  action: Action,
 ): action is ResetProjectsStateAction {
   return isActionOf(
     [projectsActions.deleteProjects.success, allEntitiesFlushed],

diff --git a/src/redux/reduxTools.ts b/src/redux/reduxTools.ts
@@ -5,7 +5,7 @@ export {
   createReducer,
   createSelector,
   nanoid,
-  type AnyAction,
+  type Action,
   type Selector,
 } from "@reduxjs/toolkit";
 

diff --git a/src/redux/tags/tagsReducer.ts b/src/redux/tags/tagsReducer.ts
@@ -5,18 +5,18 @@ import { allEntitiesFlushed } from "~/redux/allEntities/allEntitiesActions";
 import {
   createReducer,
   isActionOf,
+  type Action,
   type ActionType,
-  type AnyAction,
 } from "~/redux/reduxTools";
 import { Mapping, type Tag } from "~/types";
 
 import * as tagsActions from "./tagsActions";
 
-export interface TagsState {
-  readonly source: Dictionary<Tag>;
-  readonly target: Dictionary<Tag>;
-  readonly isFetching: boolean;
-}
+export type TagsState = Readonly<{
+  source: Dictionary<Tag>;
+  target: Dictionary<Tag>;
+  isFetching: boolean;
+}>;
 
 export const tagsInitialState: TagsState = {
   source: {},
@@ -64,7 +64,7 @@ type TagsCreateOrFetchSuccessAction = ActionType<
 >;
 
 function isTagsApiSuccessAction(
-  action: AnyAction,
+  action: Action,
 ): action is TagsCreateOrFetchSuccessAction {
   return isActionOf(
     [tagsActions.createTags.success, tagsActions.fetchTags.success],
@@ -79,7 +79,7 @@ type TagsApiRequestAction = ActionType<
 >;
 
 function isTagsApiRequestAction(
-  action: AnyAction,
+  action: Action,
 ): action is TagsApiRequestAction {
   return isActionOf(
     [
@@ -98,7 +98,7 @@ type TagsApiFailureAction = ActionType<
 >;
 
 function isTagsApiFailureAction(
-  action: AnyAction,
+  action: Action,
 ): action is TagsApiFailureAction {
   return isActionOf(
     [
@@ -115,7 +115,7 @@ type ResetTagsStateAction = ActionType<
 >;
 
 function isResetTagsStateAction(
-  action: AnyAction,
+  action: Action,
 ): action is ResetTagsStateAction {
   return isActionOf(
     [tagsActions.deleteTags.success, allEntitiesFlushed],

diff --git a/src/redux/tasks/tasksReducer.ts b/src/redux/tasks/tasksReducer.ts
@@ -5,18 +5,18 @@ import { allEntitiesFlushed } from "~/redux/allEntities/allEntitiesActions";
 import {
   createReducer,
   isActionOf,
+  type Action,
   type ActionType,
-  type AnyAction,
 } from "~/redux/reduxTools";
 import { Mapping, type Task } from "~/types";
 
 import * as tasksActions from "./tasksActions";
 
-export interface TasksState {
-  readonly source: Dictionary<Task>;
-  readonly target: Dictionary<Task>;
-  readonly isFetching: boolean;
-}
+export type TasksState = Readonly<{
+  source: Dictionary<Task>;
+  target: Dictionary<Task>;
+  isFetching: boolean;
+}>;
 
 export const tasksInitialState: TasksState = {
   source: {},
@@ -75,7 +75,7 @@ type TasksCreateOrFetchSuccessAction = ActionType<
 >;
 
 function isTasksApiSuccessAction(
-  action: AnyAction,
+  action: Action,
 ): action is TasksCreateOrFetchSuccessAction {
   return isActionOf(
     [tasksActions.createTasks.success, tasksActions.fetchTasks.success],
@@ -90,7 +90,7 @@ type TasksApiRequestAction = ActionType<
 >;
 
 function isTasksApiRequestAction(
-  action: AnyAction,
+  action: Action,
 ): action is TasksApiRequestAction {
   return isActionOf(
     [
@@ -109,7 +109,7 @@ type TasksApiFailureAction = ActionType<
 >;
 
 function isTasksApiFailureAction(
-  action: AnyAction,
+  action: Action,
 ): action is TasksApiFailureAction {
   return isActionOf(
     [
@@ -126,7 +126,7 @@ type ResetTasksStateAction = ActionType<
 >;
 
 function isResetTasksStateAction(
-  action: AnyAction,
+  action: Action,
 ): action is ResetTasksStateAction {
   return isActionOf(
     [tasksActions.deleteTasks.success, allEntitiesFlushed],