-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MultiCount Interface #236
base: main
Are you sure you want to change the base?
Conversation
structure, with small changes to add the storage of an extra value in the BTree Structure. I chose to maintain this structure for consistency with the MultiSelect to make it clear what I have done, but I imagine that there is a better data structure for the problem.
Hey! This looks pretty great impl-wise, I'm interested in hearing more about the use-cases for this prompt type. Was there something specific you needed that made you create this PR? |
Hi! Thanks for getting back to me. Yes, I had a situation where single units (As in MultiSelect) were not enough (specifically, billable hours in different categories). I'll get on with the conversion to a struct and get back to you. |
One question: |
…ges in formatter and doctests
Would you be interested in this feature being included in repository? If so, is there anything else you need from me? |
Hey @wegreenall, I think this would be a nice addition yes, just haven't had the proper time to go through the PR yet |
Adds a MultiCount interface. This extends the MultiSelect to allow for (integer) numerical counts. Rather than doing anything complicated, the count is incremented/decremented with the right and left arrows, and incremented/decremented by ten using shift and right, left arrow respectively. I stuck close to the MultiSelect paradigm to minimise the difference from old code in large commits for new features, to make it easier to compare.
If accepted I will add an appropriate README paragraph (it felt rather brash otherwise).