Add tests that previous ones did not cover #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is split from mihaimaruseac#593 to reduce the PR's size.
toku-sa-n
commented
Sep 22, 2022
Comment on lines
-135
to
153
| Type declaration with infix promoted type constructor | ||
| Type declaration with promoted lists | ||
|
|
||
| ```haskell | ||
| fun1 :: Def ('[ Ref s (Stored Uint32), IBool] 'T.:-> IBool) | ||
| fun1 :: Def ('[ Ref s (Stored Uint32), IBool] T.:-> IBool) | ||
| fun1 = undefined | ||
|
|
||
| fun2 :: Def ('[ Ref s (Stored Uint32), IBool] ':-> IBool) | ||
| fun2 :: Def ('[ Ref s (Stored Uint32), IBool] :-> IBool) | ||
| fun2 = undefined | ||
| ``` |
There was a problem hiding this comment.
ghc-lib-parser doesn't hold the information whether a promoted infix operator has a ' as a prefix, but infix operators don't need it.
A single quote is used to disambiguate a data constructor from a type with the same name, but a type never contains symbol characters only. Thus, we don't need to add the prefix.
toku-sa-n
commented
Sep 22, 2022
Comment on lines
-1741
to
-1742
| foreign import ccall "test" test :: IO () | ||
|
|
There was a problem hiding this comment.
ghc-lib-parser doesn't have information on whether the safe keyword is omitted. Thus, we can't test this line.
Another option is to omit safe always.
|
Now that #593 contains tests that fail on the original HIndent, splitting a PR makes a complex merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split from #593 to reduce its size.