Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpuid] Update option ENABLE_DOCS to LIBCPUID_ENABLE_DOCS #43244

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

autoantwort
Copy link
Contributor

Fixes

-- Performing post-build validation
warning: /debug/share should not exist. Please reorganize any important files, then use
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share")
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: /Users/leanderSchulten/git_projekte/vcpkg2/ports/cpuid/portfile.cmake
error: building cpuid:arm64-osx failed with: POST_BUILD_CHECKS_FAILED

(found by x-test-features)

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Jan 14, 2025
@WangWeiLin-MV
Copy link
Contributor

Using the latest version of vcpkg for local installation does not reproduce the issue.

vcpkg install cpuid:arm64-osx

Please append the repro commands or steps.

@autoantwort
Copy link
Contributor Author

autoantwort commented Jan 14, 2025

  1. Remove installed folder
  2. Run vcpkg x-set-installed --enforce-port-checks cpuid --binarysource=clear

@WangWeiLin-MV
Copy link
Contributor

WangWeiLin-MV commented Jan 14, 2025

  1. Remove installed folder
  2. Run vcpkg x-set-installed --enforce-port-checks cpuid --binarysource=clear

Sorry I still haven’t repro it, but only got the warning:

-- Configuring x64-windows
CMake Warning at installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:344 (message):
  The following variables are not used in CMakeLists.txt:

      ENABLE_DOCS

  Please recheck them and remove the unnecessary options from the
  `vcpkg_cmake_configure` call.

  If these options should still be passed for whatever reason, please use the
  `MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
  ports/cpuid/portfile.cmake:13 (vcpkg_cmake_configure)
  scripts/ports.cmake:196 (include)


-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.3.0-1-any.pkg.tar.zst.
-- Using cached msys2-msys2-runtime-3.5.4-2-x86_64.pkg.tar.zst.
-- Using msys root at ****/downloads//tools/msys2/21caed2f81ec917b
-- Installing: ****/packages/cpuid_x64-windows/share/cpuid/copyright
-- Performing post-build validation
Elapsed time to handle cpuid:x64-windows: 11 s
cpuid:x64-windows package ABI: ****
Total install time: 11 s
cpuid provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(cpuid CONFIG REQUIRED)
  target_link_libraries(main PRIVATE cpuid::cpuid)


UPDATE:

It passed on x64-osx too.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 14, 2025

It would fail in CI if there was an empty directory.
But there is this ENABLE_DOCS warning.
Maybe there is an installation order problem?

@autoantwort
Copy link
Contributor Author

image Happens probably because doxygen was found on my PC but not on yours.

@autoantwort
Copy link
Contributor Author

I have now fixed the root cause.

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jan 14, 2025
@WangWeiLin-MV WangWeiLin-MV changed the title [cpuid] fix [cpuid] Update option ENABLE_DOCS to LIBCPUID_ENABLE_DOCS Jan 14, 2025
@vicroms vicroms merged commit 6159d3e into microsoft:master Jan 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants