Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liboqs] New port #43225

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[liboqs] New port #43225

merged 1 commit into from
Jan 14, 2025

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Jan 12, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev talregev changed the title Add liboqs [liboqs] New port Jan 12, 2025
@talregev talregev force-pushed the TalR/liboqs branch 6 times, most recently from 7561078 to 64cafda Compare January 12, 2025 13:29
@talregev talregev marked this pull request as ready for review January 12, 2025 13:40
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 13, 2025
@JonLiu1993
Copy link
Member

Tested usage successfully by liboqs:x64-windows.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2025
ports/liboqs/portfile.cmake Outdated Show resolved Hide resolved
Signed-off-by: Tal Regev <[email protected]>
@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2025
@talregev
Copy link
Contributor Author

talregev commented Jan 13, 2025

@JonLiu1993 Why you removed the review label?

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2025
@vicroms vicroms merged commit 4d752d3 into microsoft:master Jan 14, 2025
17 checks passed
@talregev talregev deleted the TalR/liboqs branch January 14, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants