Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpng] update to 1.6.45 #43200

Merged
merged 8 commits into from
Jan 14, 2025
Merged

[libpng] update to 1.6.45 #43200

merged 8 commits into from
Jan 14, 2025

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Jan 10, 2025 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt
Copy link
Contributor

dg0yt commented Jan 10, 2025

Today everything is squashed into a single patch. Tomorrow nobody will know what belongs together, what must be kept and what can be dropped 🤔

@c8ef
Copy link
Contributor Author

c8ef commented Jan 11, 2025

Today everything is squashed into a single patch. Tomorrow nobody will know what belongs together, what must be kept and what can be dropped 🤔

I partially agree with you, but multiple patches for a single file can also be tricky.

@c8ef
Copy link
Contributor Author

c8ef commented Jan 11, 2025

It seems like the CI failed due to a failed git fetch. I will try again.

@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Jan 13, 2025
WangWeiLin-MV
WangWeiLin-MV approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux

ports/libpng/cmake.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch checked.

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2025
@dg0yt
Copy link
Contributor

dg0yt commented Jan 13, 2025

I partially agree with you, but multiple patches for a single file can also be tricky.

I know, but was it tricky here?

@vicroms vicroms merged commit ad5e113 into microsoft:master Jan 14, 2025
17 checks passed
@c8ef c8ef deleted the libpng branch January 14, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c8ef @dg0yt @WangWeiLin-MV @vicroms