[openvino] update to 2024.5.0 #42259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
culhatsker
force-pushed
the
openvino/2024.5.0
branch
2 times, most recently
from
c2570ce to
250b799
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
LilyWangLL
added
the
category:port-update
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LilyWangLL
added
the
requires:all-feature-testing
|
The build error from CI pipeline test: |
|
And I test all features locally, there are the following errors: My install command: |
culhatsker
force-pushed
the
openvino/2024.5.0
branch
2 times, most recently
from
c256a4d to
7db379c
Compare
|
@LilyWangLL may I ask your help? I'm afraid there's something wrong with arm64_windows pipelines as it can't find python3 executable in a few stages. May I ask you to have a look or refer someone else who can help with that? |
|
Hello everyone, I have an issue with arm64_windows builds, but I suspect that there's something wrong with the build environment. I will remove draft label from this PR. |
|
arm64-windows: |
|
If it needs python, the portfile needs vcpkg_find_acquire_program(PYTHON3)
vcpkg_cmake_configure(
...
"-DPYTHON_EXECUTABLE=${PYTHON3}" |
culhatsker
force-pushed
the
openvino/2024.5.0
branch
3 times, most recently
from
321c4f9 to
752b281
Compare
|
@LilyWangLL can this be merged? |
Please fix this failure, it still exists. |
culhatsker
force-pushed
the
openvino/2024.5.0
branch
from
752b281 to
5e819f7
Compare
|
@LilyWangLL may I ask you to check the build again? |
|
All features passed with following triplets: Usage test passed on |
LilyWangLL
requested changes
Dec 17, 2024
Comment on lines
+100
to
+109
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH DEP_SOURCE_PATH | ||
| REPO gabime/spdlog | ||
| REF v1.15.0 | ||
| SHA512 3dd98409f4625ae4d46ef5f59a2fc22a6e151a13dba9d37433363e5d84eab7cca73b379eeb637d8f9b1f0f5a42221c0cc9a2a70414dc2b6af6a162e19fba0647 | ||
| ) | ||
| file(REMOVE_RECURSE "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/spdlog") | ||
| file(COPY "${DEP_SOURCE_PATH}/include/" | ||
| DESTINATION "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/") |
There was a problem hiding this comment.
Can these be replaced with dependency spdlog?
There was a problem hiding this comment.
I tried to replace it with a regular dependency, but it requires having "SYSTEM_SPDLOG=ON" variable in level_zero cmake and for some reason when I set this variable in the root project it did not reach level_zero.
There was a problem hiding this comment.
@LilyWangLL changing dependencies of dependencies is not of current PR
let's separate product update vs work on dependencies
There was a problem hiding this comment.
I'd rather not add new vendored dependencies to this port. This should use the vcpkg spdlog port as a dependency.
There was a problem hiding this comment.
level-zero has an option to use system spdlog via SYSTEM_SPDLOG
looks like we need to enable it.
There was a problem hiding this comment.
looks like it's even better to use level-zero enabled in vcpkg #42904
we can use this patch openvinotoolkit/openvino#27633 to be able to find system version of level-zero
@LilyWangLL @JavierMatosD can we merge current PR as upgrade of OpenVINO to newer version and in next PR will submit patch to vcpkg's level-zero migration?
LilyWangLL
removed
the
requires:all-feature-testing
ports/openvino/portfile.cmake
Outdated
| @@ -64,26 +63,28 @@ if(ENABLE_INTEL_CPU) | |||
| SHA512 8d6dd319924135b7b22940d623305bf200b812ae64cde79000709de4fad429fbd43794301ef16e6f10ed7132777b7a73e9f30ecae7c030aea80d57d7c0ce4500 | |||
| ) | |||
| file(COPY "${DEP_SOURCE_PATH}/" DESTINATION "${SOURCE_PATH}/src/plugins/intel_cpu/thirdparty/mlas") | |||
| endif() | |||
|
|
|||
| if(VCPKG_TARGET_ARCHITECTURE MATCHES "arm") | |||
There was a problem hiding this comment.
why was it moved outside of ENABLE_INTEL_CPU section?
ARM Compute is required only for CPU
There was a problem hiding this comment.
I assumed I need to fix arm64-windows build. It would fail looking up python3 executable (required for scons to compile arm compute library). I fixed python3 lookup just to find out the code for arm cpu branch doesn't execute because of the cpu feature constraint platform: !(windows & arm). Because cpu is the only plugin existing for arm I assumed that it doesn't make sense to build openvino entirely without plugins and moved the arm cpu code out of the intel cpu branch.
Maybe I should have just disabled build for arm64-windows (or "arm & windows" how it is defined in cpu feature constraints) entirely.
There was a problem hiding this comment.
to build ARM compute for Windows arm6, you need clang-cl compiler and native compilation.
So, currently no way to build CPU plugin for Windows arm64
There was a problem hiding this comment.
Then I will disable openvino for windows on arm at all so that it doesn't start arm64-windows build and doesn't trigger the error
There was a problem hiding this comment.
applied patch to avoid fail if python is not available.
Comment on lines
+100
to
+109
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH DEP_SOURCE_PATH | ||
| REPO gabime/spdlog | ||
| REF v1.15.0 | ||
| SHA512 3dd98409f4625ae4d46ef5f59a2fc22a6e151a13dba9d37433363e5d84eab7cca73b379eeb637d8f9b1f0f5a42221c0cc9a2a70414dc2b6af6a162e19fba0647 | ||
| ) | ||
| file(REMOVE_RECURSE "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/spdlog") | ||
| file(COPY "${DEP_SOURCE_PATH}/include/" | ||
| DESTINATION "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/") |
There was a problem hiding this comment.
@LilyWangLL changing dependencies of dependencies is not of current PR
let's separate product update vs work on dependencies
culhatsker
force-pushed
the
openvino/2024.5.0
branch
from
5e819f7 to
2f1026c
Compare
culhatsker
force-pushed
the
openvino/2024.5.0
branch
from
2f1026c to
d2bcbcf
Compare
ilya-lavrenov
approved these changes
Dec 20, 2024
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino
that referenced
this pull request
Dec 20, 2024
### Details: - See microsoft/vcpkg#42259 (comment)
ilya-lavrenov
added a commit
to openvinotoolkit/openvino
that referenced
this pull request
Dec 20, 2024
### Details: - See microsoft/vcpkg#42259 (comment)
11happy
pushed a commit
to 11happy/openvino
that referenced
this pull request
Dec 23, 2024
LilyWangLL
approved these changes
Dec 24, 2024
JavierMatosD
requested changes
Dec 30, 2024
Comment on lines
+100
to
+109
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH DEP_SOURCE_PATH | ||
| REPO gabime/spdlog | ||
| REF v1.15.0 | ||
| SHA512 3dd98409f4625ae4d46ef5f59a2fc22a6e151a13dba9d37433363e5d84eab7cca73b379eeb637d8f9b1f0f5a42221c0cc9a2a70414dc2b6af6a162e19fba0647 | ||
| ) | ||
| file(REMOVE_RECURSE "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/spdlog") | ||
| file(COPY "${DEP_SOURCE_PATH}/include/" | ||
| DESTINATION "${SOURCE_PATH}/thirdparty/level_zero/level-zero/third_party/spdlog_headers/") |
There was a problem hiding this comment.
I'd rather not add new vendored dependencies to this port. This should use the vcpkg spdlog port as a dependency.
|
Can be closed in favor #43053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.