Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ms-gsl] update GSL to version 4.1.0 #41703

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ms-gsl] update GSL to version 4.1.0 #41703

wants to merge 3 commits into from
+10 −6

Conversation

carsonRadtke
Copy link

@carsonRadtke carsonRadtke commented Oct 21, 2024 •
edited
Loading

GSL version 4.1.0 was released on 10/21/24.

Release notes: https://github.com/microsoft/GSL/releases/tag/v4.1.0

If this PR updates an existing port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@carsonRadtke carsonRadtke changed the title update GSL to version 4.1.0 [ms-gsl] update GSL to version 4.1.0 Oct 21, 2024
@carsonRadtke
update GSL to version 4.1.0
258d629 
GSL version 4.1.0 was released on 10/21/24.

Release notes: https://github.com/microsoft/GSL/releases/tag/v4.1.0
@carsonRadtke carsonRadtke marked this pull request as ready for review October 21, 2024 18:50
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 22, 2024
MonicaLiu0311
MonicaLiu0311 reviewed Oct 22, 2024
View reviewed changes
ports/ms-gsl/portfile.cmake
@@ -2,8 +2,8 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO Microsoft/GSL
REF a3534567187d2edc428efd3f13466ff75fe5805c
SHA512 5bd6aad37fee3b56a2ee2fed10d6ef02fdcf37a1f40b3fb1bbec8146a573e235169b315405d010ab75175674ed82658c8202f40b128a849c5250b4a1b8b0a1b3
REF v4.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF v4.1.0
REF "v${VERSION}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from the "version" field in vcpkg.json.

@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented Oct 22, 2024 •
edited
Loading

file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

You can use vcpkg_install_copyright():
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 left review comments

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonRadtke @MonicaLiu0311