Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CI image to Android NDK r27c #41647

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Switch CI image to Android NDK r27c #41647

wants to merge 3 commits into from
+4 −4

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 18, 2024

r27c seems mature enough to be used in vcpkg CI.
Similar to the r26 transition:

  1. Add r27c to the image. This PR, plus @BillyONeal doing the actual rollout.
  2. Switch CI with android NDK r27c #40339 to use the new NDK from the image, fix and merge.
  3. Remove r26c from the image. Future PR.

@BillyONeal
Copy link
Member

Do they need to be installed concurrently or can I just give you one with only r27c you can merge in #40339 ?

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 19, 2024 •
edited
Loading

The NDKs are not needed to be installed concurrently.

@dg0yt dg0yt mentioned this pull request Oct 19, 2024
Draft
6 tasks
@dg0yt dg0yt changed the title Add Android NDK r27c to CI image Switch CI image to Android NDK r27c Oct 20, 2024
@FrankXie05 FrankXie05 self-assigned this Oct 21, 2024
@FrankXie05 FrankXie05 added the category:infrastructure Pertaining to the CI/Testing infrastrucutre label Oct 21, 2024
FrankXie05
FrankXie05 previously approved these changes Oct 21, 2024
View reviewed changes
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2024
BillyONeal
BillyONeal reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs edit to

scripts/azure-pipelines/android/azure-pipelines.yml

@BillyONeal
Copy link
Member

BillyONeal commented Oct 21, 2024 •
edited
Loading

dg0yt#25 I prepared and pushed an image with these changes for you

@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2024
@dg0yt dg0yt marked this pull request as draft October 22, 2024 06:27
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 22, 2024

Rolled back to stop redundant CI. Actual integration now in #40339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

@FrankXie05 FrankXie05 FrankXie05 left review comments

Assignees

@FrankXie05 FrankXie05

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dg0yt @BillyONeal @FrankXie05