[many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 #29882

JackBoosY · 2023-02-27T07:53:20Z

JackBoosY · 2023-02-28T06:46:05Z

depends on #28084

JackBoosY · 2023-03-01T07:45:53Z

@JackBoosY
Can you separate the failed ports to different PRs?

There is no rush, so we can wait for the dependent PRs to be merged.

talregev · 2023-03-01T07:54:43Z

@JackBoosY
Can you separate the failed ports to different PRs?

There is no rush, so we can wait for the dependent PRs to be merged.

Can you put a links for dependent PRs that you are waiting for this PR? Put them in the top comment will help.
Thank you for your hard work!

JackBoosY · 2023-03-01T08:26:00Z

@JackBoosY
Can you separate the failed ports to different PRs?

There is no rush, so we can wait for the dependent PRs to be merged.

Can you put a links for dependent PRs that you are waiting for this PR? Put them in the top comment will help. Thank you for your hard work!

Once #28084 was merged, I will merge this PR to master.

ports/kd-soap/portfile.cmake

MonicaLiu0311 · 2023-03-21T10:52:15Z

@JackBoosY
Convert this PR to draft since there is no progress. Please ping us if this PR is ready for review again.

BillyONeal · 2023-04-19T04:06:23Z

#26981 covered a lot of the same ground and as a result some of the changes that are left only add quotes. Do you still think we should have those changes or should we drop the merely quote changes?

BillyONeal · 2023-04-19T04:07:06Z

ports/functions-framework-cpp/portfile.cmake

-file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
-vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake PACKAGE_NAME share)
+file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
+vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake)


Note that #26981 added PACKAGE_NAME share which seems wrong so I resolved the conflict in favor of the changes here.

JackBoosY · 2023-04-19T04:09:04Z

@BillyONeal We still need to switch vcpkg_fixup_cmake_targets to vcpkg_config_cmake_fixup.
This PR is preparing for #29830 and #30070 so we can continue PR microsoft/vcpkg-tool#675

BillyONeal · 2023-04-19T04:13:39Z

@BillyONeal We still need to switch vcpkg_fixup_cmake_targets to vcpkg_config_cmake_fixup. This PR is preparing for #29830 and #30070 so we can continue PR microsoft/vcpkg-tool#675

I don't see any left:

JackBoosY · 2023-04-19T04:15:08Z

@BillyONeal We still need to switch vcpkg_fixup_cmake_targets to vcpkg_config_cmake_fixup. This PR is preparing for #29830 and #30070 so we can continue PR microsoft/vcpkg-tool#675

I don't see any left:

ports/ignition-modularscripts/vcpkg-port-config.cmake , so we needs to merge #29916 first.

talregev · 2023-04-19T08:11:03Z

@JackBoosY Do you still insist not to separate this port?

JackBoosY · 2023-04-19T09:25:44Z

@JackBoosY Do you still insist not to separate this port?

Why do we need to separate them?

talregev · 2023-04-19T09:29:52Z

@JackBoosY Do you still insist not to separate this port?

Why do we need to separate them?

For the ports that not connected to the errors and not need to wait for other PRs, can be fixed and be on the master.

…s0219-msft

…s0219-msft .

JackBoosY · 2023-04-21T03:25:45Z

@JackBoosY Do you still insist not to separate this port?

Why do we need to separate them?

For the ports that not connected to the errors and not need to wait for other PRs, can be fixed and be on the master.

But they are done for fix.

BillyONeal · 2023-04-21T21:48:14Z

Thank you!

jyu49 added 3 commits February 27, 2023 15:52

[many ports]switch to vcpkg-cmake / vckg-cmake-config

17b6a3c

format manifest

bddbd7b

version

8aa7fe3

JackBoosY mentioned this pull request Feb 27, 2023

[many ports]switch to vcpkg-cmake / vckg-cmake-config part 3 #29883

Merged

jyu49 added 2 commits February 27, 2023 16:15

typo

5e0a5e8

version

ea5d0d5

Adela0814 assigned MonicaLiu0311 Feb 27, 2023

jyu49 added 5 commits February 27, 2023 17:40

typo

ad3e2b9

version

4bacdfb

fix typo

2598042

fix include

d7d5e65

version

dcd7085

JackBoosY mentioned this pull request Feb 28, 2023

Add new post check for share folder microsoft/vcpkg-tool#675

Open

jyu49 added 7 commits February 28, 2023 13:18

re-fix include

06b5227

version

2411825

re-fix include

753d2f6

version

7a648d3

fix copyright path

2532a46

re-fix include

b2e2473

version

0a27a2f

JackBoosY mentioned this pull request Feb 28, 2023

[vcpkg] Move include ports.cmake after defining multiple macros #29916

Merged

jyu49 added 2 commits February 28, 2023 14:26

deprecate TARGET_PATH

861d4fb

version

0c4743b

jyu49 added 3 commits March 1, 2023 10:41

deprecated vcpkg_extract_source_archive_ex

cda92ea

version

338352e

fix arguments

72320cb

JackBoosY mentioned this pull request Mar 7, 2023

[vcpkg scripts] Remove deprecate functions vcpkg_*_cmake and vcpkg_fixup_cmake_targets #30070

Closed

Osyotr reviewed Mar 7, 2023

View reviewed changes

ports/kd-soap/portfile.cmake Show resolved Hide resolved

MonicaLiu0311 marked this pull request as draft March 21, 2023 10:52

Merge remote-tracking branch 'origin/master' into HEAD

e049a59

BillyONeal marked this pull request as ready for review April 19, 2023 04:03

BillyONeal reviewed Apr 19, 2023

View reviewed changes

BillyONeal previously approved these changes Apr 19, 2023

View reviewed changes

BillyONeal added 2 commits April 20, 2023 16:15

Merge remote-tracking branch 'origin/master' into HEAD

4547ebd

Use relative paths for host-to-host dependencies, as suggested by @ra…

145032f

…s0219-msft .

BillyONeal dismissed their stale review via 145032f April 21, 2023 00:46

jyu49 added 2 commits April 21, 2023 11:30

typo

7d7676c

version

97b9b4b

MonicaLiu0311 changed the title ~~[many ports]switch to vcpkg-cmake / vckg-cmake-config part 2~~ [many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 Apr 21, 2023

MonicaLiu0311 approved these changes Apr 21, 2023

View reviewed changes

MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 21, 2023

BillyONeal merged commit 7cfd63d into microsoft:master Apr 21, 2023

JackBoosY deleted the dev/jack/cleanup_vcpkg_fixup_cmake_targets_2 branch April 22, 2023 00:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 #29882

[many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 #29882

JackBoosY commented Feb 27, 2023

JackBoosY commented Feb 28, 2023 •

edited

Loading

JackBoosY commented Mar 1, 2023

talregev commented Mar 1, 2023

JackBoosY commented Mar 1, 2023

MonicaLiu0311 commented Mar 21, 2023

BillyONeal commented Apr 19, 2023

BillyONeal Apr 19, 2023 •

edited

Loading

JackBoosY commented Apr 19, 2023

BillyONeal commented Apr 19, 2023

JackBoosY commented Apr 19, 2023 •

edited

Loading

talregev commented Apr 19, 2023

JackBoosY commented Apr 19, 2023

talregev commented Apr 19, 2023 •

edited

Loading

JackBoosY commented Apr 21, 2023

BillyONeal commented Apr 21, 2023

[many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 #29882

[many ports]switch to vcpkg-cmake / vcpkg-cmake-config part 2 #29882

Conversation

JackBoosY commented Feb 27, 2023

JackBoosY commented Feb 28, 2023 • edited Loading

JackBoosY commented Mar 1, 2023

talregev commented Mar 1, 2023

JackBoosY commented Mar 1, 2023

MonicaLiu0311 commented Mar 21, 2023

BillyONeal commented Apr 19, 2023

BillyONeal Apr 19, 2023 • edited Loading

Choose a reason for hiding this comment

JackBoosY commented Apr 19, 2023

BillyONeal commented Apr 19, 2023

JackBoosY commented Apr 19, 2023 • edited Loading

talregev commented Apr 19, 2023

JackBoosY commented Apr 19, 2023

talregev commented Apr 19, 2023 • edited Loading

JackBoosY commented Apr 21, 2023

BillyONeal commented Apr 21, 2023

JackBoosY commented Feb 28, 2023 •

edited

Loading

BillyONeal Apr 19, 2023 •

edited

Loading

JackBoosY commented Apr 19, 2023 •

edited

Loading

talregev commented Apr 19, 2023 •

edited

Loading