Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kql_dashboard): onboard new resource/data-source #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

close #134

❓ What are you trying to address

Onboard new Resource/Data-Source: fabric_kql_dashboard

Copy link

github-actions bot commented Jan 25, 2025

Changelog Preview

v0.1.0-dev - January 27, 2025

💥 Breaking

  • #171 The format attribute is now REQUIRED for Resources/Data-Sources with definition support.
    Currently applicable to the following Resources/Data-Sources: Report, Notebook, Semantic Model, and Spark Job Definition.

  • #185 Using preview resources or data sources now needs explicit opt-in at the provider level configuration by setting the preview attribute to true.
    This is to ensure that users are aware of the risks of using preview resources or data sources in production environments.
    Usage of any preview feature will result in a warning message in the Terraform output.

✨ Added

  • #168 Added support for multi-format Notebook Resource/Data-Source.
    By using format attribute, you can now define the format of the Notebook Resource/Data-Source. Accepted values are jpynb, and py.

  • #171 Added support for multi-format Report Resource/Data-Source.
    By using format attribute, you can now define the format of the Report Resource/Data-Source. Accepted values are PBIR, and PBIR-Legacy.

  • #171 Added support for multi-format Semantic Model Resource/Data-Source.
    By using format attribute, you can now define the format of the Semantic Model Resource/Data-Source. Accepted values are TMSL, and TMDL.

  • #135 Definition support in the fabric_eventhouse Resource

  • #156 Definition support in the fabric_eventhouse Data-Sources

  • #201 Added additional properties for fabric_spark_workspace_settings Data-Source and Resource:

  • high_concurrency.notebook_pipeline_run_enabled (Boolean)
  • job.conservative_job_admission_enabled (Boolen)
  • job.session_timeout_in_minutes (Number)
  • #134 New Resource/Data-Source: fabric_kql_dashboard

💫 Changed

  • #194 Enabled SPN support for Warehouse

🪲 Fixed

  • #174 Provider produced inconsistent result after apply error appears when using fabric_domain_workspace_assignments multiple times due to enforce assignments based only on TF configuration and ignoring the real state on the Fabric side.
    Resource must only manage TF provided configuration and ignore any configuration provided outside TF.

  • #190 Fixed typo in the "Creating an App Registration for the User context" doc

@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Jan 25, 2025
Copy link

github-actions bot commented Jan 25, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 80% 0
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 83% 0
github.com/microsoft/terraform-provider-fabric/internal/provider 87% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 69% 0
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/domain 42% 0
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/spark 75% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0
Summary 73% (4024 / 5512) 0

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.83%. Comparing base (29d4dc6) to head (21026e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   76.72%   76.83%   +0.11%     
==========================================
  Files         151      154       +3     
  Lines       13175    13225      +50     
==========================================
+ Hits        10109    10162      +53     
+ Misses       3062     3059       -3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DS-LS] Integrate KQL Dashboards as Fabric Item list data-source
2 participants