This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Extend support to Python3 and PyTorch 0.4.1 #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just made some modifications in order to be able to run
valid.py
andtrain.py
using Python3 and the most recent versions of PyTorch. I believe all changes proposed are backwards compatible with the original targeted versions of Python and PyTorch, mentioned in README.md.With the changes proposed, running
with the original data provided, produced the following output.
I looks ok-ish, but I would be good to have some confirmation from your side that was no deterioration in performance. I will be performing the porting to the training routine later on.