HdfConverter: GitHub requires the uri to have a non-empty string value

GitHub Advanced Security code scanning requires 'physicalLocation.artifactLocation.uri' to have a non-empty string value, so default to using the ruleId if no other value is available. Signed-off-by: Craig Andrews <[email protected]>
microsoft · Jul 28, 2023 · 4ffc769 · 4ffc769
1 parent f11a3df
commit 4ffc769
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/Sarif.Converters/HdfConverter.cs b/src/Sarif.Converters/HdfConverter.cs
@@ -173,7 +173,7 @@ private static (ReportingDescriptor, IList<Result>) SarifRuleAndResultFromHdfCon
                             {
                                 ArtifactLocation = new ArtifactLocation
                                 {
-                                   Uri =  new Uri(execJsonControl.SourceLocation.Ref ?? "", UriKind.Relative),
+                                   Uri =  new Uri(execJsonControl.SourceLocation.Ref ?? execJsonControl.Id, UriKind.Relative),
                                    UriBaseId = "ROOTPATH",
                                 },
                                 Region = new Region