Skip to content

Commit

Permalink
Rule fix + rebase test data (#2797)
Browse files Browse the repository at this point in the history
* Fixes

* Rebase test data due to ADO2012 base class fix
  • Loading branch information
EasyRhinoMSFT authored Feb 29, 2024
1 parent f6a32c6 commit 23dfdcf
Show file tree
Hide file tree
Showing 10 changed files with 434 additions and 2,074 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
namespace Microsoft.CodeAnalysis.Sarif.Multitool.Rules
{
public class AdoProvideRequiredReportingDescriptorProperties
: BaseProvideRequiredResultProperties
: BaseProvideRequiredReportingDescriptorProperties
{
/// <summary>
/// ADO2012
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace Microsoft.CodeAnalysis.Sarif.Multitool.Rules
{
public class Base2012ProvideRequiredReportingDescriptorProperties
public class BaseProvideRequiredReportingDescriptorProperties
: SarifValidationSkimmerBase
{
public override string Id => string.Empty;
Expand All @@ -15,7 +15,7 @@ public class Base2012ProvideRequiredReportingDescriptorProperties
nameof(RuleResources.Base2012_ProvideRequiredReportingDescriptorProperties_Error_MissingIdProperty_Text)
};

private ICollection<string> BaseMessageResourceNames => _baseMessageResourceNames;
protected ICollection<string> BaseMessageResourceNames => _baseMessageResourceNames;

public override HashSet<RuleKind> RuleKinds => new HashSet<RuleKind>();

Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 23dfdcf

Please sign in to comment.