-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upgrade] add tests to build process #787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iseabock
force-pushed
the
NO-TASK-add-test-to-build-process
branch
from
April 16, 2024 22:03
68f5ccf
to
108e584
Compare
Thanks for setting up the tests! I noticed a few static files were removed. Was that intentional? Just checking if any regenerated files need to be readded. |
abhahn
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rafaelbaum
pushed a commit
to rafaelbaum/sample
that referenced
this pull request
May 6, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
rafaelbaum
pushed a commit
to rafaelbaum/sample
that referenced
this pull request
May 10, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
sudo-init
pushed a commit
to sudo-init/sample-app-chatGPT
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
nikhilnagaraj
pushed a commit
to Admin-bh-Edge/Edge-Comp-Policies
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Since frontend test have been included in the repo they should be included into the build process.
Description
This was added to the last process in the build process and a polyfill was added to support modern Javascript in Node 14.x
Contribution Checklist