Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade] add tests to build process #787

Merged
merged 16 commits into from
Apr 19, 2024
Merged

Conversation

iseabock
Copy link
Contributor

@iseabock iseabock commented Apr 16, 2024

Motivation and Context

Since frontend test have been included in the repo they should be included into the build process.

Description

This was added to the last process in the build process and a polyfill was added to support modern Javascript in Node 14.x

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

@iseabock iseabock force-pushed the NO-TASK-add-test-to-build-process branch from 68f5ccf to 108e584 Compare April 16, 2024 22:03
@abhahn
Copy link
Member

abhahn commented Apr 19, 2024

Thanks for setting up the tests!

I noticed a few static files were removed. Was that intentional? Just checking if any regenerated files need to be readded.

Copy link
Member

@abhahn abhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iseabock iseabock merged commit fb0929c into main Apr 19, 2024
5 checks passed
@iseabock iseabock deleted the NO-TASK-add-test-to-build-process branch April 19, 2024 22:13
rafaelbaum pushed a commit to rafaelbaum/sample that referenced this pull request May 6, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
rafaelbaum pushed a commit to rafaelbaum/sample that referenced this pull request May 10, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants