test(mc): initial multicloud IaC boilerplate GKE, AKS, Kind #1268
+4,500
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 1. Docker installed on the host machine | ||
|
|
||
| ## Quickstart |
There was a problem hiding this comment.
I would suggest creating sub-items under Quickstart for AKS/GKE/Kind and put all steps to create each of them in corresponding section. I think it's easier to read and follow. And a separate section for Cleanup/Destroy on same level as Quickstart
| default_node_pool { | ||
| name = "agentpool" | ||
| node_count = 2 | ||
| vm_size = "Standard_D4ds_v5" |
There was a problem hiding this comment.
can node_count and vm_size also be set with input variables? This would help setting up a broader range of test scenarios
| load_balancer_profile { | ||
| managed_outbound_ip_count = 1 | ||
| } | ||
| pod_cidr = "10.244.0.0/16" |
There was a problem hiding this comment.
can pod_cidr be settable? More IPs are needed for scale tests
| vm_size = "Standard_D4ds_v5" | ||
| os_disk_size_gb = 128 | ||
| os_disk_type = "Ephemeral" | ||
| max_pods = 110 |
There was a problem hiding this comment.
can max_pods be set to 250?
| @@ -0,0 +1,5 @@ | |||
| variable "retina_version" { | |||
There was a problem hiding this comment.
is it possible to provide a path to a values.yaml file with desired override values to deploy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial work on multi-cloud
Related Issue
#1267
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
All modules were tested and work as expected.
See automated tests here https://github.com/microsoft/retina/actions/runs/12952871303/job/36131206491
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.