Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advanced retina performance test workflows #1264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ritwikranjan
Copy link
Contributor

Description

This pull request includes changes to the GitHub Actions workflows to add a new advanced performance test and rename the existing performance test to basic performance test. The changes affect both the .github/workflows/images.yaml and .github/workflows/perf.yaml files.

The most important changes include:

Workflow updates:

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@ritwikranjan ritwikranjan requested a review from a team as a code owner January 23, 2025 19:55
- name: Setup go
uses: actions/setup-go@v5
with:
go-version-file: go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use go-version, since go-version-file is only superficially functional. From the docs:

The go-version-file input accepts a path to a go.mod file or a go.work file that contains the version of Go to be used by a project.
The go directive in go.mod can specify a patch version or omit it altogether (e.g., go 1.22.0 or go 1.22).
If a patch version is specified, that specific patch version will be used.

Which is in direct conflict with the go.mod spec which states:

Syntax

go minimum-go-version

minimum-go-version
The minimum version of Go required to compile packages > in this module.

This is an open issue here: actions/setup-go#543

Plus, parameterizing go-version would allow us to use a matrix to do early testing for pre-release go versions to detect performance regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants