Skip to content

Commit

Permalink
fix: inconsistent label cardinality error in latency metric (#687)
Browse files Browse the repository at this point in the history
# Description

As title. Closes #561 
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
  • Loading branch information
nddq authored Sep 4, 2024
1 parent 309842b commit 76962f7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/module/metrics/latency.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ func NewLatencyMetrics(ctxOptions *api.MetricsContextOptions, fl *log.ZapLogger,
exporter.AdvancedRegistry,
noResponseFromNodeAPIServerName,
noResponseFromNodeAPIServerDesc,
"no_response",
)
}

Expand Down

0 comments on commit 76962f7

Please sign in to comment.