refactor(textinput): rename event payload properties for spelling and grammer callbacks #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
Saadnajmi
force-pushed
the
fabric/text-input-grammer-2
branch
from
240a75f to
a974384
Compare
tido64
reviewed
Jan 16, 2025
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
tido64
reviewed
Jan 16, 2025
packages/react-native/Libraries/Components/TextInput/TextInput.d.ts
Outdated
Show resolved
Hide resolved
Saadnajmi
force-pushed
the
fabric/text-input-grammer-2
branch
from
6ea9b25 to
4db3790
Compare
Saadnajmi
force-pushed
the
fabric/text-input-grammer-2
branch
from
4db3790 to
f6e2935
Compare
tido64
approved these changes
Jan 20, 2025
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Tommy Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
#2290 must merge first
Summary:
macOS TextInput has some specific "Spelling And Grammar" properties that can be enabled or disabled by the user. We had events/callbacks to listen for these changes, with a simple "enabled" as the payload. While working on #2290 I realized it would make more sense to have seprate payloads for each event (spellCheckEnabled, etc). This is however, a breaking change, as it changes what is sent to JS.
Test Plan:
Testing...
BREAKING CHANGE: textinput spelling and grammar callbacks event changed