Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicated log record issue.
Description
Set parent property
propagate
ofQlibLogger
to False.Motivation and Context
If the official python
logging
module is called somewhere during qlib run, after its call, the same qlib log record will get printed twice with different format, e.g. execute below code snippetleads to below result (note the last two lines):
After some investigation, found that the qlib logger organised with hierarchy
<qlib.log.QlibLogger qlib.mytest (INFO)>-<logging.Logger qlib (DEBUG)>-><logging.RootLogger root (WARNING)>
, and the log record generated in QlibLogger is propagated to the<logging.Logger qlib (DEBUG)>
to be emitted. By default it will also be propagated to the root level, but by default root level has no handler so no emission occurs.However, direct call of
logging
will automatically addStreamHandler
to theRootLogger
, thus we seelogger.info("see duplicate")
gets emitted twice.Therefore to fix this we need to truncate the propagation at the second level.
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
After fix the code snippet gives:
The duplicate record disappears.
Types of changes