Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the validation of local media_save API #3784

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Sep 25, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow SDK CLI Azure E2E Test Result users/ninhu/media_save_fix

  4 files    4 suites   4m 18s ⏱️
244 tests 204 ✅  40 💤 0 ❌
976 runs  816 ✅ 160 💤 0 ❌

Results for commit e938323.

Copy link

SDK CLI Global Config Test Result users/ninhu/media_save_fix

6 tests   6 ✅  1m 31s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit e938323.

Copy link

Executor Unit Test Result users/ninhu/media_save_fix

798 tests   798 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e938323.

Copy link

Executor E2E Test Result users/ninhu/media_save_fix

246 tests   239 ✅  5m 2s ⏱️
  1 suites    6 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit e938323.

Copy link

SDK CLI Test Result users/ninhu/media_save_fix

    4 files      4 suites   1h 4m 57s ⏱️
  790 tests   767 ✅ 23 💤 0 ❌
3 160 runs  3 068 ✅ 92 💤 0 ❌

Results for commit e938323.

@ninghu ninghu merged commit 14d8164 into main Sep 25, 2024
37 of 41 checks passed
@ninghu ninghu deleted the users/ninhu/media_save_fix branch September 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants