Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Doc CI issues #3783

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Fix Build Doc CI issues #3783

merged 13 commits into from
Oct 31, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Sep 24, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Sep 24, 2024

promptflow SDK CLI Azure E2E Test Result users/ninhu/media_save_disable

  4 files    4 suites   4m 20s ⏱️
244 tests 204 ✅  40 💤 0 ❌
976 runs  816 ✅ 160 💤 0 ❌

Results for commit a3e212c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 24, 2024

SDK CLI Global Config Test Result users/ninhu/media_save_disable

6 tests   6 ✅  1m 22s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit a3e212c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 24, 2024

Executor Unit Test Result users/ninhu/media_save_disable

798 tests   798 ✅  3m 43s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit a3e212c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 24, 2024

Executor E2E Test Result users/ninhu/media_save_disable

245 tests   239 ✅  5m 2s ⏱️
  1 suites    6 💤
  1 files      0 ❌

Results for commit a3e212c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 24, 2024

SDK CLI Test Result users/ninhu/media_save_disable

    4 files      4 suites   1h 4m 42s ⏱️
  790 tests   767 ✅ 23 💤 0 ❌
3 160 runs  3 068 ✅ 92 💤 0 ❌

Results for commit a3e212c.

♻️ This comment has been updated with latest results.

@ninghu ninghu dismissed stale reviews from nagkumar91 and luigiw via cf22ba6 October 31, 2024 19:47
@ninghu ninghu changed the title Fix CI pipeline failures Fix Doc CI issues Oct 31, 2024
@ninghu ninghu changed the title Fix Doc CI issues Fix Build Doc CI issues Oct 31, 2024
@ninghu ninghu merged commit 9345ad3 into main Oct 31, 2024
10 of 15 checks passed
@ninghu ninghu deleted the users/ninhu/media_save_disable branch October 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Improvements on examples no-recent-activity There has been no recent activity on this issue/pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants