Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[promptflow-evals] evaluator config support #2963

Merged
merged 7 commits into from
Apr 26, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Apr 23, 2024

Description

Using an example to explain of how evaluator config works in evaluate API:

Data: col1, col2
Target: col3

Mapping:
question -> ${data.col1}
answer -> ${target.col3}

Evaluate API Workflow

  1. Update evaluator config

    • Replace all "${target." with "${data."
    • New mapping:
      question -> ${data.col1}
      answer -> ${data.col3}
  2. Apply target to data

    • New data: col1, col2, col3
  3. Column validation

    • For each evaluator, rename column:
      • col1->question, col3->answer
      • question, col2, answer
    • Compare with evaluator signature
  4. Call evaluator

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu requested a review from a team as a code owner April 23, 2024 22:18
nagkumar91
nagkumar91 previously approved these changes Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

promptflow-evals test result

 12 files   12 suites   1h 54m 18s ⏱️
 15 tests  15 ✅ 0 💤 0 ❌
180 runs  180 ✅ 0 💤 0 ❌

Results for commit 5b86460.

♻️ This comment has been updated with latest results.

nick863
nick863 previously approved these changes Apr 23, 2024
@ninghu ninghu dismissed stale reviews from nick863 and nagkumar91 via ccf1ee9 April 24, 2024 23:02
@ninghu ninghu changed the title [promptflow-evals] evaluator config support for data [promptflow-evals] evaluator config support Apr 25, 2024
nick863
nick863 previously approved these changes Apr 25, 2024
@ninghu ninghu merged commit 89c5bbb into main Apr 26, 2024
39 checks passed
@ninghu ninghu deleted the useres/ninhu/evalualtor_config branch April 26, 2024 16:02
crazygao pushed a commit that referenced this pull request May 6, 2024
# Description

Using an example to explain of how evaluator config works in evaluate
API:

Data: col1, col2
Target: col3

Mapping:
   question -> ${data.col1} 
   answer -> ${target.col3}


Evaluate API Workflow

1. Update evaluator config
    - Replace all "${target." with "${data."
    - New mapping:
		    question -> ${data.col1} 
		    answer -> ${data.col3}	

1. Apply target to data
     - New data: col1, col2, col3

1. Column validation
    - For each evaluator, rename column: 
       - col1->question, col3->answer
       - question, col2, answer
    - Compare with evaluator signature

1. Call evaluator


# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants