Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] Create CI for sample service #1334

Merged
merged 21 commits into from
Dec 7, 2023
Merged

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Nov 30, 2023

This pull request includes various updates to documentation files and workflow files for improved organization and triggering conditions. The most important changes include renaming and updating the content of a readme file, updating triggering conditions for multiple workflow files, and adding a new workflow file for running daily and on pull requests.

Documentation updates:

  • examples/tutorials/flow-deploy/create-service-with-flow/README.md: Renamed readme.md to README.md and updated its content to include instructions on starting the service and testing it with a request.
  • examples/README.md: Added a new entry for the create-service-with-flow example, including a badge for the workflow and a brief description.

Workflow updates:

  • .github/workflows/samples_tutorials_flow_deploy_create_service_with_flow.yml: Added a new workflow file that runs daily and on pull requests, with various steps including generating config files, setting up environments, running scripts, and uploading artifacts.
  • .github/workflows/samples_tutorials_flow_deploy_kubernetes.yml: Updated triggering conditions to include the examples/flows/integrations/** path on pull requests.
  • .github/workflows/samples_tutorials_flow_deploy_distribute_flow_as_executable_app.yml: Updated workflow file to remove the exclusion of the examples/flows/integrations/** path from triggering the workflow on pull requests.
  • .github/workflows/samples_tutorials_e2e_development_chat_with_pdf.yml: Updated triggering conditions to remove the exclusion of the examples/flows/integrations/** path from triggering the workflow on pull requests.
  • .github/workflows/samples_configuration.yml: Updated triggering conditions to remove the exclusion of examples/flows/integrations/** and add an exclusion for files ending with requirements.txt.
  • .github/workflows/samples_tutorials_flow_deploy_azure_app_service.yml: Updated triggering conditions to remove the exclusion of the examples/flows/integrations/** path.
  • .github/workflows/samples_tutorials_flow_deploy_docker.yml: Updated triggering conditions to remove the exclusion of the examples/flows/integrations/** path from triggering the workflow on pull requests.
  • .github/workflows/samples_tutorials_flow_fine_tuning_evaluation_promptflow_quality_improvement.yml: Updated triggering conditions to remove the exclusion of the examples/flows/integrations/** path from triggering the workflow on pull requests.# Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested a review from a team as a code owner November 30, 2023 09:12
@github-actions github-actions bot added examples Improvements on examples fundamental labels Nov 30, 2023
@D-W- D-W- closed this Nov 30, 2023
@D-W- D-W- reopened this Nov 30, 2023
@D-W- D-W- requested a review from a team as a code owner December 6, 2023 06:27
@wangchao1230 wangchao1230 merged commit 449d679 into main Dec 7, 2023
51 checks passed
@wangchao1230 wangchao1230 deleted the wanhan/add_score_ci branch December 7, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Improvements on examples fundamental
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants