Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PromptFlow] Fix can't raise exception in processpool's run. #1237

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

Hhhilulu
Copy link
Contributor

@Hhhilulu Hhhilulu commented Nov 22, 2023

Description

Problem
The wait() method of starmap_async only waits for the result and does not capture exceptions.

Solution:
Use async_result.get() to propagate exceptions if they are raised.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Nov 22, 2023

SDK CLI Global Config Test Result luluzuo/fix_async_starmap

2 tests   2 ✔️  1m 3s ⏱️
1 suites  0 💤
1 files    0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

Executor Unit Test Result luluzuo/fix_async_starmap

563 tests   562 ✔️  49s ⏱️
    1 suites      1 💤
    1 files        0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

@Hhhilulu Hhhilulu changed the title add async.get() [PromptFlow] Fix can't raise exception in processpool's run. Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

Executor E2E Test Result luluzuo/fix_async_starmap

140 tests   136 ✔️  2m 26s ⏱️
    1 suites      4 💤
    1 files        0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

SDK PFS E2E Test Result luluzuo/fix_async_starmap

  2 files    2 suites   49s ⏱️
  9 tests   9 ✔️ 0 💤 0
18 runs  18 ✔️ 0 💤 0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

promptflow SDK CLI Azure E2E Test Result luluzuo/fix_async_starmap

    2 files      2 suites   1m 57s ⏱️
  99 tests   77 ✔️ 22 💤 0
198 runs  154 ✔️ 44 💤 0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

SDK CLI Test Result luluzuo/fix_async_starmap

2 files  2 suites   20s ⏱️
1 tests 1 ✔️ 0 💤 0
2 runs  2 ✔️ 0 💤 0

Results for commit aef128e.

♻️ This comment has been updated with latest results.

@Hhhilulu Hhhilulu force-pushed the luluzuo/fix_async_starmap branch from aac5d2b to aef128e Compare November 22, 2023 11:27
@github-actions github-actions bot removed the examples Improvements on examples label Nov 22, 2023
@Hhhilulu Hhhilulu merged commit e4e7b71 into main Nov 22, 2023
33 checks passed
@Hhhilulu Hhhilulu deleted the luluzuo/fix_async_starmap branch November 22, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants