-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PromptFlow] Fix can't raise exception in processpool's run. #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hhhilulu
changed the title
add async.get()
[PromptFlow] Fix can't raise exception in processpool's run.
Nov 22, 2023
thy09
reviewed
Nov 22, 2023
src/promptflow/promptflow/executor/_line_execution_process_pool.py
Outdated
Show resolved
Hide resolved
guming-learning
previously approved these changes
Nov 22, 2023
guming-learning
previously approved these changes
Nov 22, 2023
Hhhilulu
force-pushed
the
luluzuo/fix_async_starmap
branch
from
November 22, 2023 11:27
aac5d2b
to
aef128e
Compare
thy09
approved these changes
Nov 22, 2023
PeiwenGaoMS
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
The wait() method of starmap_async only waits for the result and does not capture exceptions.
Solution:
Use async_result.get() to propagate exceptions if they are raised.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines