-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize complexity of filter out unwanted recognizers from O(n*m ) to O(n) #1508
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
|
||
all_possible_recognizers = copy.copy(self.recognizers) | ||
if ad_hoc_recognizers: | ||
all_possible_recognizers.extend(ad_hoc_recognizers) | ||
|
||
for rec in all_possible_recognizers: | ||
if type(rec.supported_entities) == list and len(rec.supported_entities) > 0: | ||
all_entity_recognizers.update(dict.fromkeys(rec.supported_entities, rec)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If multiple recognizers support the same entity, only the last one will be stored in the dictionary. This could lead to unintended behavior if the order of recognizers matters.
all_entity_recognizers.update(dict.fromkeys(rec.supported_entities, rec)) | |
all_entity_recognizers.setdefault(entity, []).append(rec) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Hi, thanks for creating this PR! Assuming it is possible for multiple recognizers to support the same entity, how to this mapping look like? |
Change Description
Code refactor.
Improve complexity of filter out unwanted recognizers from O(n*m )to O(n)
In current code for loop is running inside for loop that makes complexity to O(n*m). after this change there is only one loop by using one extra variable.
where
m = total number of all_possible_recognizers
n= total supported entities which we want to include .
Describe your changes
Issue reference
This PR fixes issue #XX
Checklist