-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load analyzer configuration from file #1337
load analyzer configuration from file #1337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is a great addition which would allow easy configuration not just for the Docker based capabilities, but also for a better code-free configuration. Added a few comments, but happy to discuss each of those as most of them are mainly a matter of style rather than correctness.
Fixes #1338 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left lots of comments but it's definitely in the right direction. Feel free to reach out if you want to discuss any of those.
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
|
||
return recognizers | ||
|
||
def _load_recognizer_registry(self) -> RecognizerRegistry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _load_recognizer_registry(self) -> RecognizerRegistry: | |
def _load_recognizer_registry(self) -> Optional[RecognizerRegistry]: |
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, left some minor comments
Hey.
Logs :
|
presidio-analyzer/presidio_analyzer/recognizer_registry_provider.py
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Sharon Hart <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
db37325
into
microsoft:feature/engines_from_conf
load analyzer configuration from file
giving the option to load analyzer from configuration file. It'll enable loading of:
Issue reference
This PR fixes issue #1338
Checklist