Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type mismatch in check_label_groups parameter in SpacyRecognizer #1130

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix type mismatch in check_label_groups parameter in SpacyRecognizer #1130

merged 2 commits into from
Aug 14, 2023

Conversation

Nitrino
Copy link
Contributor

@Nitrino Nitrino commented Jul 28, 2023 •
edited
Loading

Change Description

This PR fixes a type mismatch of the check_label_groups parameter in SpacyRecognizer.

The default value is of type List[Tuple[Set, Set]], and the received parameter is of type Tuple[Set, Set]

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374
Copy link
Contributor

omri374 commented Aug 14, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 3effc14 into microsoft:main Aug 14, 2023
23 checks passed
@omri374
Copy link
Contributor

omri374 commented Aug 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitrino @omri374