Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] TabView v2 #70

Merged
merged 6 commits into from
Mar 25, 2020
Merged

[WIP] TabView v2 #70

merged 6 commits into from
Mar 25, 2020

Conversation

stmoy
Copy link
Contributor

@stmoy stmoy commented Mar 6, 2020

Spec corresponding to: microsoft/microsoft-ui-xaml#2007

@stmoy stmoy requested a review from a team as a code owner March 6, 2020 02:29
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
{
Equal = 0,
SizeToContent = 1,
Compact = 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new field (Compact) should be marked preview. And for the purposes of this documentation, we should do something to indicate that the first two fields exist already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for CCing! I am not quite sure if there is a way to mark only one enum value as preview, I haven't found a comparable example in the project. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually maybe that's not necessary, I don't think we've been versioning the changes in MUXC. @ranjeshj?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. There is no versioning from what I understand, just preview (pre-release) or stable. I don't think the version is necessary since we go down-level. @jevansaks to correct me if I am wrong here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning would work here and you might want to if this enum value might stay under preview even through the next major release. Otherwise I agree it probably doesn't matter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we just add it to the normal enum without marking that entry as preview?

active/TabView/TabView_v2.md Outdated Show resolved Hide resolved
@stmoy stmoy requested review from MikeHillberg and ranjeshj March 20, 2020 18:12
@stmoy stmoy changed the base branch from master to TabView_v2_review March 25, 2020 17:31
@stmoy stmoy merged commit 153f78d into TabView_v2_review Mar 25, 2020
MikeHillberg pushed a commit that referenced this pull request Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants