-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TabView v2 #70
[WIP] TabView v2 #70
Conversation
{ | ||
Equal = 0, | ||
SizeToContent = 1, | ||
Compact = 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new field (Compact) should be marked preview. And for the purposes of this documentation, we should do something to indicate that the first two fields exist already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @chingucoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for CCing! I am not quite sure if there is a way to mark only one enum value as preview, I haven't found a comparable example in the project. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually maybe that's not necessary, I don't think we've been versioning the changes in MUXC. @ranjeshj?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. There is no versioning from what I understand, just preview (pre-release) or stable. I don't think the version is necessary since we go down-level. @jevansaks to correct me if I am wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versioning would work here and you might want to if this enum value might stay under preview even through the next major release. Otherwise I agree it probably doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we just add it to the normal enum without marking that entry as preview?
Co-Authored-By: MikeHillberg <[email protected]>
Spec corresponding to: microsoft/microsoft-ui-xaml#2007