-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: process null values #1248
fix: process null values #1248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for starting this. I have left a number of comments to move it forward.
b3a45ff
to
10bf9d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're making good progress here! Thanks for the continuous efforts.
Signed-off-by: Vincent Biret <[email protected]>
Great! I just comitted changes to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Kindest13 I believe you still need to reply to the policy service bot to get this merged.
@microsoft-github-policy-service agree |
Now this PR is ready, I'd like us to get started on the generation updates before we merge this pull request. |
Would be great if you can share more info on this |
My guess is that since the Let us know if you have additional questions. |
I would ask to describe in more details what should be done. |
|
Hey @baywet, is that correct? |
yes it looks correct, however I left a couple of comments on the PR to wrap it up. |
Fixes #1188
1 part for processing null values